Remove presubmit warning for long lines in .grd files

tests/presubmit_unittest.py

 #!/usr/bin/env python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for presubmit_support.py and presubmit_canned_checks.py."""
 
 # pylint is too confused.
 # pylint: disable=E1101,E1103,R0201,W0212,W0403
 
@@ skipping 1374 matching lines @@
       Args:
         check: the check to run.
         content1: content which is expected to pass the check.
         content2: content which is expected to fail the check.
         error_type: the type of the error expected for content2.
     """
     change1 = presubmit.Change(
         'foo1', 'foo1\n', self.fake_root_dir, None, 0, 0, None)
     input_api1 = self.MockInputApi(change1, False)
     affected_file = self.mox.CreateMock(presubmit.SvnAffectedFile)
-    input_api1.AffectedFiles(mox.IgnoreArg(), include_deletes=False).AndReturn(
-        [affected_file])
+    input_api1.AffectedFiles(
+        include_deletes=False,
+        file_filter=mox.IgnoreArg()).AndReturn([affected_file])
     affected_file.NewContents().AndReturn([
         'ahoy',
         'yo' + content1,
         'hay',
         'yer',
         'ya'])
 
     change2 = presubmit.Change(
         'foo2', 'foo2\n', self.fake_root_dir, None, 0, 0, None)
     input_api2 = self.MockInputApi(change2, False)
 
-    input_api2.AffectedFiles(mox.IgnoreArg(), include_deletes=False).AndReturn(
-        [affected_file])
+    input_api2.AffectedFiles(
+        include_deletes=False,
+        file_filter=mox.IgnoreArg()).AndReturn([affected_file])
     affected_file.NewContents().AndReturn([
         'ahoy',
         'yo' + content2,
         'hay',
         'yer',
         'ya'])
     affected_file.ChangedContents().AndReturn([
         (42, 'yo, ' + content2),
         (43, 'yer'),
         (23, 'ya')])
@@ skipping 169 matching lines @@
     # Only this one will trigger.
     affected_file4 = self.mox.CreateMock(presubmit.SvnAffectedFile)
     affected_file4.LocalPath().AndReturn('makefile.foo')
     affected_file1.NewContents().AndReturn(['yo, '])
     affected_file4.NewContents().AndReturn(['ye\t'])
     affected_file4.ChangedContents().AndReturn([(46, 'ye\t')])
     affected_file4.LocalPath().AndReturn('makefile.foo')
     affected_files = (affected_file1, affected_file2,
                       affected_file3, affected_file4)
 
-    def test(source_filter, include_deletes):
+    def test(file_filter, include_deletes):
       self.assertFalse(include_deletes)
       for x in affected_files:
-        if source_filter(x):
+        if file_filter(x):
           yield x
     # Override the mock of these functions.
     input_api1.FilterSourceFile = lambda x: x
     input_api1.AffectedFiles = test
     self.mox.ReplayAll()
 
     results1 = presubmit_canned_checks.CheckChangeHasNoTabs(input_api1,
         presubmit.OutputApi, None)
     self.assertEquals(len(results1), 1)
     self.assertEquals(results1[0].__class__,
@@ skipping 98 matching lines @@
     change.GetModifiedFiles().AndReturn([modified_dir_file])
     change.GetAllModifiedFiles().AndReturn([modified_dir_file,
                                             accidental_submssion_file])
     input_api = self.MockInputApi(change, True)
 
     affected_file = self.mox.CreateMock(presubmit.SvnAffectedFile)
     affected_file.Action().AndReturn('M')
     affected_file.IsDirectory().AndReturn(True)
     affected_file.AbsoluteLocalPath().AndReturn(accidental_submssion_file)
     affected_file.LocalPath().AndReturn(accidental_submssion_file)
-    input_api.AffectedFiles(None).AndReturn([affected_file])
+    input_api.AffectedFiles(file_filter=None).AndReturn([affected_file])
 
     self.mox.ReplayAll()
 
     check = presubmit_canned_checks.CheckSvnModifiedDirectories
     results = check(input_api, presubmit.OutputApi, None)
     self.assertEquals(len(results), 1)
     self.assertEquals(results[0].__class__,
                       presubmit.OutputApi.PresubmitPromptWarning)
 
   def testCheckSvnForCommonMimeTypes(self):
@@ skipping 257 matching lines @@
     affected_file = self.mox.CreateMock(presubmit.SvnAffectedFile)
     input_api = self.MockInputApi(change, False)
     fake_db = self.mox.CreateMock(owners.Database)
     fake_db.email_regexp = input_api.re.compile(owners.BASIC_EMAIL_REGEXP)
     input_api.owners_db = fake_db
     input_api.is_committing = True
     input_api.tbr = tbr
 
     if not tbr and issue:
       affected_file.LocalPath().AndReturn('foo.cc')
-      change.AffectedFiles(None).AndReturn([affected_file])
+      change.AffectedFiles(file_filter=None).AndReturn([affected_file])
 
       expected_host = 'http://localhost'
       if host_url:
         input_api.host_url = host_url
         if host_url.startswith('https'):
           expected_host = host_url
 
       owner_email = 'john@example.com'
       messages = list('{"sender": "' + a + '","text": "lgtm"}' for
                       a in approvers)
@@ skipping 134 matching lines @@
         whitelist=['^a$', '^b$'],
         blacklist=['a'])
     self.assertEqual(results, [])
     self.checkstdout(
         'Running %s\n' % presubmit.os.path.join('random_directory', 'b'))
 
 
 if __name__ == '__main__':
   import unittest
   unittest.main()