Remove presubmit warning for long lines in .grd files

presubmit_canned_checks.py

 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 
 ### Description checks
 
 def CheckChangeHasTestField(input_api, output_api):
@@ skipping 135 matching lines @@
   if input_api.change.scm != 'svn':
     return []
 
   errors = []
   current_cl_files = input_api.change.GetModifiedFiles()
   all_modified_files = input_api.change.GetAllModifiedFiles()
   # Filter out files in the current CL.
   modified_files = [f for f in all_modified_files if f not in current_cl_files]
   modified_abspaths = [input_api.os_path.abspath(f) for f in modified_files]
 
-  for f in input_api.AffectedFiles(source_file_filter):
+  for f in input_api.AffectedFiles(file_filter=source_file_filter):
     if f.Action() == 'M' and f.IsDirectory():
       curpath = f.AbsoluteLocalPath()
       bad_files = []
       # Check if any of the modified files in other CLs are under curpath.
       for i in xrange(len(modified_files)):
         abspath = modified_abspaths[i]
         if input_api.os_path.commonprefix([curpath, abspath]) == curpath:
           bad_files.append(modified_files[i])
       if bad_files:
         if input_api.is_committing:
@@ skipping 62 matching lines @@
       if the rule is satisfied and False if there was a problem.
     input_api: object to enumerate the affected files.
     source_file_filter: a filter to be passed to the input api.
     error_formatter: a callable taking (filename, line_number, line) and
       returning a formatted error string.
 
   Returns:
     A list of the newly-introduced violations reported by the rule.
   """
   errors = []
-  for f in input_api.AffectedFiles(source_file_filter, include_deletes=False):
+  for f in input_api.AffectedFiles(include_deletes=False,
+                                   file_filter=source_file_filter):
     # For speed, we do two passes, checking first the full file.  Shelling out
     # to the SCM to determine the changed region can be quite expensive on
     # Win32.  Assuming that most files will be kept problem-free, we can
     # skip the SCM operations most of the time.
     if all(callable_rule(line) for line in f.NewContents()):
       continue  # No violation found in full text: can skip considering diff.
 
     for line_num, line in f.ChangedContents():
       if not callable_rule(line):
         errors.append(error_formatter(f.LocalPath(), line_num, line))
@@ skipping 476 matching lines @@
     return []
   if input_api.tbr:
     return [output_api.PresubmitNotifyResult(
         '--tbr was specified, skipping OWNERS check')]
   if not input_api.change.issue:
     return [output_api.PresubmitError(
         "OWNERS check failed: this change has no Rietveld issue number, so "
         "we can't check it for approvals.")]
 
   affected_files = set([f.LocalPath() for f in
-      input_api.change.AffectedFiles(source_file_filter)])
+      input_api.change.AffectedFiles(file_filter=source_file_filter)])
 
   owners_db = input_api.owners_db
   owner_email, approvers = _RietveldOwnerAndApprovers(input_api,
                                                       owners_db.email_regexp)
   approvers_plus_owner = approvers.union(set([owner_email]))
 
   missing_files = owners_db.files_not_covered_by(affected_files,
                                                  approvers_plus_owner)
   if missing_files:
     return [output_api.PresubmitError('Missing LGTM from an OWNER for: %s' %
@@ skipping 203 matching lines @@
   # auto-fix most of these.
   if input_api.is_committing:
     snapshot("checking svn mime types")
     results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
         input_api, output_api))
     snapshot("checking license")
     results.extend(input_api.canned_checks.CheckLicense(
         input_api, output_api, license_header, source_file_filter=sources))
   snapshot("done")
   return results