Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5936)

Unified Diff: chrome/browser/history/download_create_info.cc

Issue 6932046: Added DownloadProcessHandle class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: download_process_handle Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/download_create_info.cc
diff --git a/chrome/browser/history/download_create_info.cc b/chrome/browser/history/download_create_info.cc
index a7ece9ab042e95a1a86e171a65e217c39dfeccfb..12b23a8ed5f67b0cd5a24a38f53a1efda2f8a730 100644
--- a/chrome/browser/history/download_create_info.cc
+++ b/chrome/browser/history/download_create_info.cc
@@ -26,9 +26,6 @@ DownloadCreateInfo::DownloadCreateInfo(const FilePath& path,
state(state),
download_id(download_id),
has_user_gesture(has_user_gesture),
- child_id(-1),
- render_view_id(-1),
- request_id(-1),
db_handle(0),
prompt_user_for_save_location(false),
is_dangerous_file(false),
@@ -43,9 +40,6 @@ DownloadCreateInfo::DownloadCreateInfo()
state(-1),
download_id(-1),
has_user_gesture(false),
- child_id(-1),
- render_view_id(-1),
- request_id(-1),
db_handle(0),
prompt_user_for_save_location(false),
is_dangerous_file(false),
@@ -62,24 +56,24 @@ bool DownloadCreateInfo::IsDangerous() {
std::string DownloadCreateInfo::DebugString() const {
return base::StringPrintf("{"
- " url_ = \"%s\""
+ " download_id = %d"
+ " url = \"%s\""
" path = \"%" PRFilePath "\""
" received_bytes = %" PRId64
" total_bytes = %" PRId64
" child_id = %d"
" render_view_id = %d"
" request_id = %d"
- " download_id = %d"
" prompt_user_for_save_location = %c"
" }",
+ download_id,
url().spec().c_str(),
path.value().c_str(),
received_bytes,
total_bytes,
- child_id,
- render_view_id,
- request_id,
- download_id,
+ process_handle.child_id(),
+ process_handle.render_view_id(),
+ process_handle.request_id(),
prompt_user_for_save_location ? 'T' : 'F');
}

Powered by Google App Engine
This is Rietveld 408576698