Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3115)

Unified Diff: chrome/browser/download/download_file_manager.h

Issue 6932046: Added DownloadProcessHandle class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: download_process_handle Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_file_manager.h
diff --git a/chrome/browser/download/download_file_manager.h b/chrome/browser/download/download_file_manager.h
index 1d96b5d154bbeaa68bb36a1c36a755ee0557f7e0..00ba8d10f169c6ebf6f3a6ddc99d9af2cdcaed08 100644
--- a/chrome/browser/download/download_file_manager.h
+++ b/chrome/browser/download/download_file_manager.h
@@ -47,6 +47,8 @@
#include "base/hash_tables.h"
#include "base/memory/ref_counted.h"
#include "base/timer.h"
+#include "chrome/browser/download/download_file.h"
Paweł Hajdan Jr. 2011/05/05 20:13:51 Why does this #include download_file? Also, if you
ahendrickson 2011/05/06 16:16:50 Removed the include.
+#include "chrome/browser/download/download_process_handle.h"
#include "ui/gfx/native_widget_types.h"
struct DownloadBuffer;
@@ -138,12 +140,13 @@ class DownloadFileManager
// Creates DownloadFile on FILE thread and continues starting the download
// process.
void CreateDownloadFile(DownloadCreateInfo* info,
+ DownloadProcessHandle process,
Paweł Hajdan Jr. 2011/05/05 20:13:51 nit: Now why not const DownloadProcessHandle& proc
ahendrickson 2011/05/06 16:16:50 Because I need to use non-const member functions.
DownloadManager* download_manager,
bool hash_needed);
// Tells the ResourceDispatcherHost to resume a download request
// that was paused to wait for the on-disk file to be created.
- void ResumeDownloadRequest(int child_id, int request_id);
+ void ResumeDownloadRequest(DownloadProcessHandle process);
Paweł Hajdan Jr. 2011/05/05 20:13:51 nit: Now why not const DownloadProcessHandle& proc
ahendrickson 2011/05/06 16:16:50 Same as above.
// Called only on the download thread.
DownloadFile* GetDownloadFile(int id);

Powered by Google App Engine
This is Rietveld 408576698