chrome/browser/download/download_manager.h - Issue 6932046: Added DownloadProcessHandle class.

Unified Diff: chrome/browser/download/download_manager.h

Issue 6932046: Added DownloadProcessHandle class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Cleanup per Pawel's comments. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/download/download_file_manager.h ('K') | « chrome/browser/download/download_item.cc ('k') | chrome/browser/download/download_manager.cc » ('j') | chrome/browser/download/download_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_manager.h

diff --git a/chrome/browser/download/download_manager.h b/chrome/browser/download/download_manager.h

index 84b83990bdc9d8b103e2cf6de26f95b2a6239305..16d07ae6cedd1ffb136a607a2330a6e8b741132a 100644

--- a/chrome/browser/download/download_manager.h

+++ b/chrome/browser/download/download_manager.h

@@ -42,6 +42,7 @@

#include "base/scoped_ptr.h"

#include "base/time.h"

#include "chrome/browser/download/download_status_updater_delegate.h"

+#include "chrome/browser/download/download_process_handle.h"

#include "chrome/browser/ui/shell_dialogs.h"

#include "content/browser/browser_thread.h"

@@ -197,7 +198,7 @@ class DownloadManager

DownloadCreateInfo info, int64 db_handle);

// Display a new download in the appropriate browser UI.

- void ShowDownloadInBrowser(const DownloadCreateInfo& info,

+ void ShowDownloadInBrowser(DownloadProcessHandle process_handle,

Paweł Hajdan Jr. 2011/05/09 19:47:31 nit: Why not a pointer?

ahendrickson 2011/05/10 18:04:43 Done. This function is only called from within on

DownloadItem* download);

// The number of in progress (including paused) downloads.

@@ -289,8 +290,7 @@ class DownloadManager

// Download cancel helper function.

void DownloadCancelledInternal(int download_id,

- int render_process_id,

- int request_id);

+ DownloadProcessHandle process_handle);

Paweł Hajdan Jr. 2011/05/09 19:47:31 nit: Why not a pointer?

ahendrickson 2011/05/10 18:04:43 Because it is ultimately passed to another thread,

// All data has been downloaded.

// |hash| is sha256 hash for the downloaded file. It is empty when the hash

@@ -306,8 +306,7 @@ class DownloadManager

// Makes the ResourceDispatcherHost pause/un-pause a download request.

// Called on the IO thread.

void PauseDownloadRequest(ResourceDispatcherHost* rdh,

- int render_process_id,

- int request_id,

+ DownloadProcessHandle process_handle,

Paweł Hajdan Jr. 2011/05/09 19:47:31 nit: Why not a pointer?

ahendrickson 2011/05/10 18:04:43 Because it's called from other threads, and this w

bool pause);

// Inform observers that the model has changed.