Added DownloadProcessHandle class.

chrome/browser/download/download_process_handle.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/download/download_process_handle.h"
+
+#include <string>
+
+#include "base/file_util.h"
+#include "base/stringprintf.h"
+#include "chrome/browser/download/download_manager.h"
+#include "chrome/browser/download/download_util.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/tab_contents/tab_util.h"
+#include "content/browser/browser_thread.h"
+#include "content/browser/renderer_host/resource_dispatcher_host.h"
+#include "content/browser/tab_contents/tab_contents.h"
+
+DownloadProcessHandle::DownloadProcessHandle()
+    : child_id_(-1), render_view_id_(-1), request_id_(-1) {
+}
+
+DownloadProcessHandle::DownloadProcessHandle(int child_id,
+                                             int render_view_id,
+                                             int request_id)
+    : child_id_(child_id),
+      render_view_id_(render_view_id),
+      request_id_(request_id) {
+}
+
+void DownloadProcessHandle::CancelDownload(ResourceDispatcherHost* rdh) {

[Paweł Hajdan Jr., 2011/05/05 20:13:51]

I'm still not convinced about having this method here. How about adding it as a
method to ResourceDispatcherHost instead? Or maybe modify
download_util::CancelDownloadRequest. It seems we always call it from non-IO
threads, which results in need for this PostTask boilerplate.

Whatever happens to CancelDownload, let's sort out this CancelDownloadRequest
mess too. It should be quite simple.

[ahendrickson, 2011/05/06 16:16:50]

Done.

+  BrowserThread::PostTask(
+      BrowserThread::IO, FROM_HERE,
+      NewRunnableFunction(&download_util::CancelDownloadRequest,
+                          rdh,
+                          child_id_,
+                          request_id_));
+}
+
+TabContents* DownloadProcessHandle::GetTabContents() {

[Paweł Hajdan Jr., 2011/05/05 20:13:51]

Please add a comment to the declaration that those methods must be called on the
UI thread.

[ahendrickson, 2011/05/06 16:16:50]

OK, but I assumed the DCHECK was comment enough.

Done.

+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  return tab_util::GetTabContentsByID(child_id_, render_view_id_);
+}
+
+DownloadManager* DownloadProcessHandle::GetDownloadManager() {
+  TabContents* contents = GetTabContents();
+  if (!contents)
+    return NULL;
+
+  Profile* profile = contents->profile();
+  if (!profile)
+    return NULL;
+
+  return profile->GetDownloadManager();
+}