chrome/browser/extensions/extension_process_manager.cc - Issue 6932038: avoid dereferencing NULL extension in ExtensionHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_process_manager.cc

Issue 6932038: avoid dereferencing NULL extension in ExtensionHost (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: reflect comments Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_process_manager.cc

diff --git a/chrome/browser/extensions/extension_process_manager.cc b/chrome/browser/extensions/extension_process_manager.cc

index f21c4f8e0203fba5b9eb0fa1a41542cfdd2a6c64..8a372871dbc63e30659dc5f1a4a8cde8db90fe32 100644

--- a/chrome/browser/extensions/extension_process_manager.cc

+++ b/chrome/browser/extensions/extension_process_manager.cc

@@ -291,7 +291,7 @@ void ExtensionProcessManager::Observe(NotificationType type,

for (ExtensionHostSet::iterator iter = background_hosts_.begin();

iter != background_hosts_.end(); ++iter) {

ExtensionHost* host = *iter;

- if (host->extension()->id() == extension->id()) {

+ if (host->extension_id() == extension->id()) {

delete host;

// |host| should deregister itself from our structures.

DCHECK(background_hosts_.find(host) == background_hosts_.end());