Enable client-side phishing detection only for canary, dev and beta builds.

Enable client-side phishing detection only for canary, dev and beta builds.

BUG=81625
TEST=NONE


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84602

[mattm, 2011-05-05 01:47:22]

Is there a story behind this? Is there a reason to have it on beta but not
stable?

I assume this would need to be merged to the branch?  Should have a bug filed
for it then.

[noelutz, 2011-05-05 01:59:13]

I've added an issue which describes the reasoning behind this.

We also want to merge this change to the m12 beta branch but it doesn't have to
necessarily be at the first cut.  We just need to merge this change with the m12
branch before we mark it stable.  Ian mentioned that there will be bug fixing
going on before we push m12 to stable.  Does that plan sound good to you?

noé.


On 2011/05/05 01:47:22, mattm wrote:
> Is there a story behind this? Is there a reason to have it on beta but not
> stable?
> 
> I assume this would need to be merged to the branch?  Should have a bug filed
> for it then.

[mattm, 2011-05-05 02:54:57]

On 2011/05/05 01:59:13, noelutz wrote:
> I've added an issue which describes the reasoning behind this.
> 
> We also want to merge this change to the m12 beta branch but it doesn't have
to
> necessarily be at the first cut.  We just need to merge this change with the
m12
> branch before we mark it stable.  Ian mentioned that there will be bug fixing
> going on before we push m12 to stable.  Does that plan sound good to you?

Yeah, that seems fine.   Change lgtm.

> noé.
> 
> 
> On 2011/05/05 01:47:22, mattm wrote:
> > Is there a story behind this? Is there a reason to have it on beta but not
> > stable?
> > 
> > I assume this would need to be merged to the branch?  Should have a bug
filed
> > for it then.

[Brian Ryner, 2011-05-05 17:18:16]

Would it be better to use platform_util::GetChannel()?

[noelutz, 2011-05-06 04:44:25]

GetChannel() is all new and shiny.  It doesn't exist in the 742 branch.

http://src.chromium.org/viewvc/chrome/branches/742/src/chrome/browser/platfor...

noé.

On 2011/05/05 17:18:16, Brian Ryner wrote:
> Would it be better to use platform_util::GetChannel()?

[Brian Ryner, 2011-05-06 18:03:38]

Ah, ok.

LGTM

On 2011/05/06 04:44:25, noelutz wrote:
> GetChannel() is all new and shiny.  It doesn't exist in the 742 branch.
> 
>
http://src.chromium.org/viewvc/chrome/branches/742/src/chrome/browser/platfor...
> 
> noé.
> 
> On 2011/05/05 17:18:16, Brian Ryner wrote:
> > Would it be better to use platform_util::GetChannel()?

[commit-bot: I haz the power, 2011-05-09 02:51:00]

Change committed as 84602