Issue 6932002: gtk/infobars: Refactor AnimateOpen/Open into a single Show() method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6932002: gtk/infobars: Refactor AnimateOpen/Open into a single Show() method. (Closed)

Created:
9 years, 7 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting, Evan Martin, Evan Stade

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

gtk/infobars: Refactor AnimateOpen/Open into a single Show() method. This now matches with the Show() method in the views side. BUG=None TEST=None R=pkasting@chromium.org,evan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84100

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -20 lines)			Patch
M	chrome/browser/ui/gtk/infobars/infobar_container_gtk.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	chrome/browser/ui/gtk/infobars/infobar_gtk.h	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/gtk/infobars/infobar_gtk.cc	View	1 chunk	+5 lines, -10 lines	0 comments	Download

Total messages: 4 (0 generated)

Evan Martin

i think estade likely wrote this. it seems fine to me.

9 years, 7 months ago (2011-05-04 14:54:02 UTC) #2

lgtm