net/http/http_network_transaction.cc - Issue 6931048: Revert 84197 - Add one-time randomization support for FieldTrial, and the ability to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_transaction.cc

Issue 6931048: Revert 84197 - Add one-time randomization support for FieldTrial, and the ability to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_network_transaction.cc

===================================================================

--- net/http/http_network_transaction.cc (revision 84367)

+++ net/http/http_network_transaction.cc (working copy)

@@ -1010,8 +1010,9 @@

base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromMinutes(10),

100);

- static const bool use_conn_impact_histogram =

- base::FieldTrialList::TrialExists("ConnCountImpact");

+ static bool use_conn_impact_histogram(

+ base::FieldTrialList::Find("ConnCountImpact") &&

+ !base::FieldTrialList::Find("ConnCountImpact")->group_name().empty());

if (use_conn_impact_histogram) {

UMA_HISTOGRAM_CLIPPED_TIMES(

base::FieldTrial::MakeName("Net.Transaction_Connected_New",

@@ -1022,8 +1023,8 @@

}

- static const bool use_spdy_histogram =

- base::FieldTrialList::TrialExists("SpdyImpact");

+ static bool use_spdy_histogram(base::FieldTrialList::Find("SpdyImpact") &&

+ !base::FieldTrialList::Find("SpdyImpact")->group_name().empty());

if (use_spdy_histogram && response_.was_npn_negotiated) {

UMA_HISTOGRAM_CLIPPED_TIMES(

base::FieldTrial::MakeName("Net.Transaction_Connected_Under_10",

« no previous file with comments | « net/http/http_cache_transaction.cc ('k') | net/socket/client_socket_pool_histograms.cc » ('j') | no next file with comments »