Add MenuItemView API to add and remove items at a particular index.

views/controls/menu/menu_controller.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/controls/menu/menu_controller.h"
 
 #include "base/i18n/case_conversion.h"
 #include "base/i18n/rtl.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
@@ skipping 1326 matching lines @@
     item->GetSubmenu()->ShowAt(owner_, bounds, do_capture);
   else
     item->GetSubmenu()->Reposition(bounds);
   showing_submenu_ = false;
 }
 
 void MenuController::MenuChildrenChanged(MenuItemView* item) {
   DCHECK(item);
   DCHECK(item->GetSubmenu()->IsShowing());
 
-  // Currently this only supports adjusting the bounds of the last menu.
-  DCHECK(item == state_.item->GetParentMenuItem());
-
-  // Make sure the submenu isn't showing for the current item (the position may
-  // have changed or the menu removed). This also moves the selection back to
-  // the parent, which handles the case where the selected item was removed.
-  SetSelection(state_.item->GetParentMenuItem(),
-               SELECTION_OPEN_SUBMENU | SELECTION_UPDATE_IMMEDIATELY);
-
-  OpenMenuImpl(item, false);
+  // If the current item is a descendant of the item that changed,
+  // move the selection back to the changed item.
+  const MenuItemView* ancestor = state_.item;

[sky, 2011/05/11 14:26:10]

You should update if either state_.item or pending_state_.item matches.

[rhashimoto, 2011/05/11 19:41:07]

Done.

+  while (ancestor && ancestor != item)
+    ancestor = ancestor->GetParentMenuItem();
+  if (ancestor) {
+    SetSelection(item, SELECTION_OPEN_SUBMENU | SELECTION_UPDATE_IMMEDIATELY);
+    OpenMenuImpl(item, false);

[sky, 2011/05/11 14:26:10]

You should only invoke OpenMenuItem if item has a submenu.

[rhashimoto, 2011/05/11 19:41:07]

Done, though I think we only get here if the item has added or removed children,
which would imply a submenu is present.  However, it is not a given that the
submenu is open on entry to MenuChildrenChanged() so I removed the DCHECK for
that.

+  }
 }
 
 void MenuController::BuildPathsAndCalculateDiff(
     MenuItemView* old_item,
     MenuItemView* new_item,
     std::vector<MenuItemView*>* old_path,
     std::vector<MenuItemView*>* new_path,
     size_t* first_diff_at) {
   DCHECK(old_path && new_path && first_diff_at);
   BuildMenuItemPath(old_item, old_path);
@@ skipping 490 matching lines @@
     return;
 
   // Reset the active_mouse_view_ before sending mouse capture lost. That way if
   // it calls back to us, we aren't in a weird state.
   View* active_view = active_mouse_view_;
   active_mouse_view_ = NULL;
   active_view->OnMouseCaptureLost();
 }
 
 }  // namespace views