Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 6931031: A tiny contribution for the IWYU day: Include allocation.h in every (Closed)

Created:
9 years, 7 months ago by Sven Panne
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

A tiny contribution for the IWYU day: Include allocation.h in every header which uses BASE_EMBEDDED and/or AllStatic. Note that still only 45 out of 135 headers in src/ can be used stand-alone, but at least this is a little bit more than before... Committed: http://code.google.com/p/v8/source/detail?r=7798

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -0 lines) Patch
M src/accessors.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arguments.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ast.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/cpu.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/cpu-profiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/d8.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/data-flow.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/dateparser.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/disassembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/execution.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/frame-element.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/frames.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gdb-jit.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/handles.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap-profiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/jsregexp.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/lithium.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/lithium-allocator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/liveedit.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/log.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/log-utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-visiting.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/preparse-data.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/prettyprinter.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/profile-generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/property.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/safepoint-table.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/scopeinfo.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/spaces.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/splay-tree.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/stub-cache.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/type-info.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/unbound-queue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/vm-state.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/zone.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
9 years, 7 months ago (2011-05-05 15:13:18 UTC) #1
Kevin Millikin (Chromium)
LGTM. Thanks.
9 years, 7 months ago (2011-05-06 04:23:57 UTC) #2
danno
9 years, 7 months ago (2011-05-06 08:18:26 UTC) #3
LGTM, too

Powered by Google App Engine
This is Rietveld 408576698