Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 6930059: Make Pepper work out-of-process in the windows sandbox (Closed)

Created:
9 years, 7 months ago by cpu_(ooo_6.6-7.5)
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, jam
Visibility:
Public.

Description

Make Pepper work out-of-process in the windows sandbox Fixes the following issues - Propper sandbox lockdown - Rand support and the Pepper module now load - Pipe creation failed - Specific sandbox policy crafted for pepper - Can now debug child process Note, the example plugin manages to draw at least a frame, then it crashes in some other unrelated bug. To test use chrome with: --register-pepper-plugins="<blah>\ppapi_example.dll;application/x-ppapi-example" --ppapi-out-of-process And can use --ppapi-startup-dialog, which hangs until you connect the debugger BUG=none TEST= see above. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84520

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -10 lines) Patch
M chrome/common/sandbox_policy.cc View 1 3 chunks +21 lines, -8 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/ppapi_plugin/ppapi_plugin_main.cc View 1 2 chunks +23 lines, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 1 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
cpu_(ooo_6.6-7.5)
9 years, 7 months ago (2011-05-06 01:34:33 UTC) #1
brettw
9 years, 7 months ago (2011-05-06 04:30:52 UTC) #2
LGTM

http://codereview.chromium.org/6930059/diff/1/content/ppapi_plugin/ppapi_plug...
File content/ppapi_plugin/ppapi_plugin_main.cc (right):

http://codereview.chromium.org/6930059/diff/1/content/ppapi_plugin/ppapi_plug...
content/ppapi_plugin/ppapi_plugin_main.cc:19: sandbox::TargetServices*
g_target_services;
It's weird you initialize the void* below and not this one. Maybe write = NULL/0
here too?

http://codereview.chromium.org/6930059/diff/1/content/ppapi_plugin/ppapi_thre...
File content/ppapi_plugin/ppapi_thread.cc (right):

http://codereview.chromium.org/6930059/diff/1/content/ppapi_plugin/ppapi_thre...
content/ppapi_plugin/ppapi_thread.cc:27: extern void* g_target_services = 0;
Don't initialize extern.

Powered by Google App Engine
This is Rietveld 408576698