Issue 6930052: Revert 84320 - Autofill DOMUI Prefs should work with i18n phone numbers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6930052: Revert 84320 - Autofill DOMUI Prefs should work with i18n phone numbers (Closed)

Created:
9 years, 7 months ago by dhollowa

Modified:
9 years, 7 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, GeorgeY, dhollowa, Ilya Sherman, arv (Not doing code reviews), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 84320 - Autofill DOMUI Prefs should work with i18n phone numbers Adds validation to the phone and fax lists in WebUI based prefs for Autofill. Also adds the start of phone_number_i18n.cc/h module. BUG=80101 TEST=PhoneNumberI18NTest.PhoneNumbersMatch Review URL: http://codereview.chromium.org/6930037 TBR=dhollowa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84346

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -280 lines)			Patch
D	chrome/browser/autofill/DEPS	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	chrome/browser/autofill/phone_number_i18n.h	View	1 chunk	+0 lines, -21 lines	0 comments	Download
D	chrome/browser/autofill/phone_number_i18n.cc	View	1 chunk	+0 lines, -36 lines	0 comments	Download
D	chrome/browser/autofill/phone_number_i18n_unittest.cc	View	1 chunk	+0 lines, -44 lines	0 comments	Download
M	chrome/browser/resources/options/autofill_edit_address_overlay.js	View	2 chunks	+2 lines, -12 lines	0 comments	Download
M	chrome/browser/resources/options/autofill_options_list.js	View	4 chunks	+2 lines, -67 lines	0 comments	Download
M	chrome/browser/ui/webui/options/autofill_options_handler.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/webui/options/autofill_options_handler.cc	View	4 chunks	+0 lines, -87 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)