Issue 6930040: Refactor to address URLRequestContext dependency added in

Issue 6930040: Refactor to address URLRequestContext dependency added in (Closed)

Created:
9 years, 7 months ago by Chris Evans

Modified:
9 years, 6 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Refactor to address URLRequestContext dependency added in http://codereview.chromium.org/6873029/ BUG=81009 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84325

Patch Set 1 #

Total comments: 4

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -25 lines)			Patch
M	content/browser/renderer_host/socket_stream_host.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/base/ssl_config_service.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/base/ssl_config_service.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	net/socket_stream/socket_stream_job.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/socket_stream/socket_stream_job.cc	View	1 chunk	+4 lines, -5 lines	2 comments	Download
M	net/url_request/url_request_context.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/url_request/url_request_context.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	net/url_request/url_request_http_job.cc	View	3 chunks	+6 lines, -3 lines	2 comments	Download
M	net/websockets/websocket_job_unittest.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/simple_socket_stream_bridge.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

LGTM, thanks! I appreciate the cleanup. http://codereview.chromium.org/6930040/diff/1/net/socket_stream/socket_stream_job.cc File net/socket_stream/socket_stream_job.cc (right): http://codereview.chromium.org/6930040/diff/1/net/socket_stream/socket_stream_job.cc#newcode30 net/socket_stream/socket_stream_job.cc:30: &domain_state, url.host(), SSLConfigService::IsSNIAvailable(ssl)) ...

9 years, 7 months ago (2011-05-05 18:00:35 UTC) #2

Chris Evans

9 years, 7 months ago (2011-05-05 22:00:56 UTC) #3

Thx; landing.

http://codereview.chromium.org/6930040/diff/1/net/socket_stream/socket_stream...
File net/socket_stream/socket_stream_job.cc (right):

http://codereview.chromium.org/6930040/diff/1/net/socket_stream/socket_stream...
net/socket_stream/socket_stream_job.cc:30: &domain_state, url.host(),
SSLConfigService::IsSNIAvailable(ssl)) &&
On 2011/05/05 18:00:35, willchan wrote:
> please include ssl_config_service.h for this

Done.

http://codereview.chromium.org/6930040/diff/1/net/url_request/url_request_htt...
File net/url_request/url_request_http_job.cc (right):

http://codereview.chromium.org/6930040/diff/1/net/url_request/url_request_htt...
net/url_request/url_request_http_job.cc:195: SSLConfigService::IsSNIAvailable(
On 2011/05/05 18:00:35, willchan wrote:
> please include ssl_config_service.h for this

Done.

Expand Messages | Collapse Messages