Issue 6930033: Replace GetStarted component extension with URL

Issue 6930033: Replace GetStarted component extension with URL (Closed)

Created:
9 years, 7 months ago by Dmitry Polukhin

Modified:
9 years, 7 months ago

Reviewers:
Nikita (slow), zel

CC:
chromium-reviews, arv (Not doing code reviews), rharrison, davemoore+watch_chromium.org, nkostylev+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Replace GetStarted component extension with URL BUG=chromium-os:14485 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85877

Patch Set 2 : tolower #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -28 lines)			Patch
M	chrome/browser/browser_resources.grd	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_controller.cc	View	1	3 chunks	+10 lines, -5 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
D	chrome/browser/resources/getstarted/manifest.json	View		1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Dmitry Polukhin

I would like to review this CL now. But I'll commit it only when server ...

9 years, 7 months ago (2011-05-11 06:40:32 UTC) #1

Nikita (slow)

http://codereview.chromium.org/6930033/diff/1/chrome/browser/chromeos/login/existing_user_controller.cc File chrome/browser/chromeos/login/existing_user_controller.cc (right): http://codereview.chromium.org/6930033/diff/1/chrome/browser/chromeos/login/existing_user_controller.cc#newcode338 chrome/browser/chromeos/login/existing_user_controller.cc:338: std::string start_url = As discussed, add conversion to lower ...

9 years, 7 months ago (2011-05-11 10:22:24 UTC) #3

Dmitry Polukhin

9 years, 7 months ago (2011-05-11 10:27:19 UTC) #4

zel

LGTM approved for merge into 742 btw, you should probably delete following directory as well: ...

9 years, 7 months ago (2011-05-19 15:44:17 UTC) #5

Dmitry Polukhin

9 years, 7 months ago (2011-05-19 16:03:08 UTC) #6

On 2011/05/19 15:44:17, zel wrote:
> LGTM
> 
> approved for merge into 742
> 
> 
> btw, you should probably delete following directory as well:
> chrome/browser/resources/getstarted

It looks like it is codereview issue. I don't see this dir in repository anymore
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/

Expand Messages | Collapse Messages