Issue 6930006: Make RegExp objects not callable.

Issue 6930006: Make RegExp objects not callable. (Closed)

Created:
9 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Make RegExp objects not callable. Committed: http://code.google.com/p/v8/source/detail?r=8068

Patch Set 2 : Updated mozilla and sputnik test expectations #

Total comments: 4

Patch Set 3 : Address review comments #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -100 lines)			Patch
M	src/execution.cc	View	1	1 chunk	+0 lines, -17 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1	1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/objects.h	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/json.js	View		5 chunks	+8 lines, -8 lines	0 comments	Download
M	test/mjsunit/number-string-index-call.js	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	test/mjsunit/override-eval-with-non-function.js	View	1 2	1 chunk	+0 lines, -36 lines	0 comments	Download
M	test/mjsunit/regexp-call-as-function.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/regress/regress-603.js	View		1 chunk	+25 lines, -10 lines	0 comments	Download
M	test/mjsunit/regress/regress-752.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/typeof.js	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	test/mozilla/mozilla.status	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	test/sputnik/sputnik.status	View	1	2 chunks	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/6930006/diff/2001/src/objects.h File src/objects.h (right): http://codereview.chromium.org/6930006/diff/2001/src/objects.h#newcode577 src/objects.h:577: // Boundary for promotion to old data ia32-v8-buildspace/old ...

9 years, 7 months ago (2011-05-25 13:11:17 UTC) #2

Lasse Reichstein

9 years, 7 months ago (2011-05-26 07:34:21 UTC) #3

http://codereview.chromium.org/6930006/diff/2001/src/objects.h
File src/objects.h (right):

http://codereview.chromium.org/6930006/diff/2001/src/objects.h#newcode577
src/objects.h:577: // Boundary for promotion to old data ia32-v8-buildspace/old
pointer space.
Argh. Fixed.

http://codereview.chromium.org/6930006/diff/2001/test/mjsunit/override-eval-w...
File test/mjsunit/override-eval-with-non-function.js (right):

http://codereview.chromium.org/6930006/diff/2001/test/mjsunit/override-eval-w...
test/mjsunit/override-eval-with-non-function.js:36: // RegExps are no longer
callable, so we don't have a callable
On 2011/05/25 13:11:17, Mads Ager wrote:
> Please just delete the test. Having a test that does nothing is silly. Either
> update to test that it throws an exception or delete.

Done.

Expand Messages | Collapse Messages