Issue 6930005: Support polymorphic loads of constant functions as well as fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6930005: Support polymorphic loads of constant functions as well as fields. (Closed)

Created:
9 years, 7 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (google), fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Support polymorphic loads of constant functions as well as fields. R=fschneider@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7792

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -70 lines)			Patch
M	src/arm/lithium-codegen-arm.h	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1	4 chunks	+23 lines, -17 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		1 chunk	+17 lines, -7 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		4 chunks	+23 lines, -17 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	4 chunks	+23 lines, -17 lines	0 comments	Download

Total messages: 4 (0 generated)

fschneider

LGTM for the ia32 part. Port to x64 and ARM is still needed.

9 years, 7 months ago (2011-05-04 14:54:28 UTC) #2

LGTM.