Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 6929008: Make Date and RegExp inherit from Object in the API. (Closed)

Created:
9 years, 7 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make Date and RegExp inherit from Object in the API. They are objects and the API inheritance hierarchy should reflect that. R=sgjesse@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -84 lines) Patch
M include/v8.h View 2 chunks +81 lines, -81 lines 0 comments Download
M src/api.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
9 years, 7 months ago (2011-05-04 06:57:57 UTC) #1
Søren Thygesen Gjesse
9 years, 7 months ago (2011-05-04 07:21:09 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698