Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 6928059: Fix newly introduced bug in detecing octal numbers. (Closed)

Created:
9 years, 7 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix newly introduced bug in detecing octal numbers. TEST=mjsunit/strict Committed: http://code.google.com/p/v8/source/detail?r=7805

Patch Set 1 #

Patch Set 2 : Added test to preparser test. Removed duplicates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -78 lines) Patch
M src/scanner-base.cc View 2 chunks +2 lines, -1 line 0 comments Download
M test/preparser/preparser.expectation View 1 1 chunk +1 line, -3 lines 0 comments Download
D test/preparser/strict-octal-directive-after.js View 1 1 chunk +0 lines, -35 lines 0 comments Download
D test/preparser/strict-octal-directive-before.js View 1 1 chunk +0 lines, -35 lines 0 comments Download
A + test/preparser/strict-octal-number.js View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
9 years, 7 months ago (2011-05-06 12:36:00 UTC) #1
Mads Ager (chromium)
9 years, 7 months ago (2011-05-06 12:41:27 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698