Enforce unicode commit message.

checkout.py

 # coding=utf8
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Manages a project checkout.
 
 Includes support for svn, git-svn and git.
 """
 
 from __future__ import with_statement
@@ skipping 277 matching lines @@
           post(self, p)
       except OSError, e:
         raise PatchApplicationFailed(p.filename, '%s%s' % (stdout, e))
       except subprocess.CalledProcessError, e:
         raise PatchApplicationFailed(
             p.filename, '%s%s' % (stdout, getattr(e, 'stdout', '')))
 
   def commit(self, commit_message, user):
     logging.info('Committing patch for %s' % user)
     assert self.commit_user
+    assert isinstance(commit_message, unicode)
     handle, commit_filename = tempfile.mkstemp(text=True)
     try:
-      os.write(handle, commit_message)
+      # Shouldn't assume default encoding is UTF-8. But really, if you are using
+      # anything else, you are living in another world.
+      os.write(handle, commit_message.encode('utf-8'))
       os.close(handle)
       # When committing, svn won't update the Revision metadata of the checkout,
       # so if svn commit returns "Committed revision 3.", svn info will still
       # return "Revision: 2". Since running svn update right after svn commit
       # creates a race condition with other committers, this code _must_ parse
       # the output of svn commit and use a regexp to grab the revision number.
       # Note that "Committed revision N." is localized but subprocess2 forces
       # LANGUAGE=en.
       args = ['commit', '--file', commit_filename]
       # realauthor is parsed by a server-side hook.
@@ skipping 109 matching lines @@
     #found_files = self._check_output_git(
     #    ['diff', 'master', '--name-only']).splitlines(False)
     #assert sorted(patches.filenames) == sorted(found_files), (
     #    sorted(out), sorted(found_files))
 
   def commit(self, commit_message, user):
     """Updates the commit message.
 
     Subclass needs to dcommit or push.
     """
+    assert isinstance(commit_message, unicode)
     self._check_call_git(['commit', '--amend', '-m', commit_message])
     return self._check_output_git(['rev-parse', 'HEAD']).strip()
 
   def _check_call_git(self, args, **kwargs):
     kwargs.setdefault('cwd', self.project_path)
     kwargs.setdefault('stdout', self.VOID)
     return subprocess2.check_call_out(['git'] + args, **kwargs)
 
   def _call_git(self, args, **kwargs):
     """Like check_call but doesn't throw on failure."""
@@ skipping 201 matching lines @@
         user, message))
     return 'FAKE'
 
   @property
   def project_name(self):
     return self.checkout.project_name
 
   @property
   def project_path(self):
     return self.checkout.project_path