Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 6928018: Linux: update xdg-utils to the latest git version and include a one-line fix in xdg-mime. (Closed)

Created:
9 years, 7 months ago by Mike Mammarella
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: update xdg-utils to the latest git version and include a one-line fix in xdg-mime for bug 80431. BUG=80431 TEST=we should not prompt to become the default every time if ~/.local/share/applications/mimeapps.list does not exist, once we roll DEPS to include this Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84156

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+546 lines, -120 lines) Patch
M ChangeLog View 1 chunk +8 lines, -0 lines 0 comments Download
M README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/xdg-desktop-icon View 2 chunks +59 lines, -1 line 0 comments Download
M scripts/xdg-desktop-icon.in View 1 chunk +1 line, -1 line 0 comments Download
M scripts/xdg-desktop-menu View 1 chunk +58 lines, -0 lines 0 comments Download
M scripts/xdg-email View 1 chunk +58 lines, -0 lines 0 comments Download
M scripts/xdg-icon-resource View 1 chunk +58 lines, -0 lines 0 comments Download
M scripts/xdg-mime View 1 6 chunks +64 lines, -5 lines 0 comments Download
M scripts/xdg-mime.in View 1 5 chunks +6 lines, -5 lines 0 comments Download
M scripts/xdg-open View 1 chunk +58 lines, -0 lines 0 comments Download
M scripts/xdg-screensaver View 1 chunk +58 lines, -0 lines 0 comments Download
M scripts/xdg-settings View 2 chunks +58 lines, -53 lines 0 comments Download
M scripts/xdg-settings.in View 1 chunk +0 lines, -53 lines 0 comments Download
M scripts/xdg-utils-common.in View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike Mammarella
9 years, 7 months ago (2011-05-04 23:04:44 UTC) #1
Lei Zhang
http://codereview.chromium.org/6928018/diff/1/scripts/xdg-mime.in File scripts/xdg-mime.in (right): http://codereview.chromium.org/6928018/diff/1/scripts/xdg-mime.in#newcode248 scripts/xdg-mime.in:248: [ -f $default_file ] || touch $default_file $default_file should ...
9 years, 7 months ago (2011-05-04 23:11:54 UTC) #2
Mike Mammarella
http://codereview.chromium.org/6928018/diff/1/scripts/xdg-mime.in File scripts/xdg-mime.in (right): http://codereview.chromium.org/6928018/diff/1/scripts/xdg-mime.in#newcode248 scripts/xdg-mime.in:248: [ -f $default_file ] || touch $default_file On 2011/05/04 ...
9 years, 7 months ago (2011-05-04 23:19:44 UTC) #3
Lei Zhang
9 years, 7 months ago (2011-05-04 23:41:26 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698