Reapply 7763, including arm and x64 variants.

Reapply 7763, including arm and x64 variants.

The only difference to revision 7763 is the implementation in the
builtins file for arm and x64, plus a move of Array.prototype.toString
and Array.prototype.toLocaleString from should throw on null or
undefined to the non generic test cases in the function-call test (due
to us not currently supporting generic cases with these to functions)
Committed: http://code.google.com/p/v8/source/detail?r=7786

[Rico, 2011-05-04 06:48:25]

Karl: Could you take a look at the arm specific changes

Lasse: Please take a look at the x64 port

[Lasse Reichstein, 2011-05-04 07:34:07]

X64 LGTM

http://codereview.chromium.org/6928007/diff/1/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):

http://codereview.chromium.org/6928007/diff/1/src/x64/builtins-x64.cc#newcode661
src/x64/builtins-x64.cc:661: // Do not transform the receiver for natives
(shared already in ebx).
More verbose comments: (SharedFunctionInfo is already loaded into rbx).

http://codereview.chromium.org/6928007/diff/1/src/x64/builtins-x64.cc#newcode663
src/x64/builtins-x64.cc:663: __ CompareRoot(rbx,
Heap::kUndefinedValueRootIndex);
Create a bug for handling non-native functions with undefined script.

http://codereview.chromium.org/6928007/diff/1/src/x64/builtins-x64.cc#newcode666
src/x64/builtins-x64.cc:666: __ SmiToInteger32(rbx, rbx);
Use 
 __ SmiToInteger32(rbx, FieldOperand(rbx, Script::kTypeOffset))
to load an integer32 from a smi memory location.

Or better yet, use
 SmiCompare(FieldOperand(rbx, Script::kTypeOffset),
Smi::FromInt(Script::TYPE_NATIVE));
to compare directly with memory.

http://codereview.chromium.org/6928007/diff/1/src/x64/builtins-x64.cc#newcode667
src/x64/builtins-x64.cc:667: __ cmpq(rbx, Immediate(Script::TYPE_NATIVE));
Should have been cmpl.

[Karl Klose, 2011-05-04 07:44:14]

http://codereview.chromium.org/6928007/diff/1/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):

http://codereview.chromium.org/6928007/diff/1/src/arm/builtins-arm.cc#newcode...
src/arm/builtins-arm.cc:1268: __ LoadRoot(r3, Heap::kUndefinedValueRootIndex);
Can you reuse the undefined value from L. 1248 here?

http://codereview.chromium.org/6928007/diff/1/test/mjsunit/function-call.js
File test/mjsunit/function-call.js (right):

http://codereview.chromium.org/6928007/diff/1/test/mjsunit/function-call.js#n...
test/mjsunit/function-call.js:74: // Non generic natives does not work on any
input other than the specific
does -> do

http://codereview.chromium.org/6928007/diff/1/test/mjsunit/function-call.js#n...
test/mjsunit/function-call.js:153: // Test that all natives using the ToObject
call throws the right exception.
throws -> throw

http://codereview.chromium.org/6928007/diff/1/test/mjsunit/function-call.js#n...
test/mjsunit/function-call.js:197: // Test that all natives that are non generic
throws on null and undefined.
throws -> throw

[Rico, 2011-05-04 08:42:18]

http://codereview.chromium.org/6928007/diff/1/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):

http://codereview.chromium.org/6928007/diff/1/src/arm/builtins-arm.cc#newcode...
src/arm/builtins-arm.cc:1268: __ LoadRoot(r3, Heap::kUndefinedValueRootIndex);
On 2011/05/04 07:44:14, Karl Klose wrote:
> Can you reuse the undefined value from L. 1248 here?

Yes, if I change the order, will do

http://codereview.chromium.org/6928007/diff/1/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):

http://codereview.chromium.org/6928007/diff/1/src/x64/builtins-x64.cc#newcode663
src/x64/builtins-x64.cc:663: __ CompareRoot(rbx,
Heap::kUndefinedValueRootIndex);
On 2011/05/04 07:34:08, Lasse Reichstein wrote:
> Create a bug for handling non-native functions with undefined script.

Don issue 1366

http://codereview.chromium.org/6928007/diff/1/src/x64/builtins-x64.cc#newcode666
src/x64/builtins-x64.cc:666: __ SmiToInteger32(rbx, rbx);
On 2011/05/04 07:34:08, Lasse Reichstein wrote:
> Use 
>  __ SmiToInteger32(rbx, FieldOperand(rbx, Script::kTypeOffset))
> to load an integer32 from a smi memory location.
> 
> Or better yet, use
>  SmiCompare(FieldOperand(rbx, Script::kTypeOffset),
> Smi::FromInt(Script::TYPE_NATIVE));
> to compare directly with memory.

Done.

http://codereview.chromium.org/6928007/diff/1/src/x64/builtins-x64.cc#newcode667
src/x64/builtins-x64.cc:667: __ cmpq(rbx, Immediate(Script::TYPE_NATIVE));
On 2011/05/04 07:34:08, Lasse Reichstein wrote:
> Should have been cmpl.

Using SmiCompare instead

http://codereview.chromium.org/6928007/diff/1/test/mjsunit/function-call.js
File test/mjsunit/function-call.js (right):

http://codereview.chromium.org/6928007/diff/1/test/mjsunit/function-call.js#n...
test/mjsunit/function-call.js:74: // Non generic natives does not work on any
input other than the specific
On 2011/05/04 07:44:14, Karl Klose wrote:
> does -> do

Done.

http://codereview.chromium.org/6928007/diff/1/test/mjsunit/function-call.js#n...
test/mjsunit/function-call.js:153: // Test that all natives using the ToObject
call throws the right exception.
On 2011/05/04 07:44:14, Karl Klose wrote:
> throws -> throw

Done.

http://codereview.chromium.org/6928007/diff/1/test/mjsunit/function-call.js#n...
test/mjsunit/function-call.js:197: // Test that all natives that are non generic
throws on null and undefined.
On 2011/05/04 07:44:14, Karl Klose wrote:
> throws -> throw

Done.