Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 6927075: Strict mode detection in preparser. (Closed)

Created:
9 years, 7 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Strict mode detection in preparser. Handle octal escapes in everything but RegExps. Extend preparser test suite to test whether the preparser reports exceptions to throw. TEST=preparser/* Committed: http://code.google.com/p/v8/source/detail?r=7804

Patch Set 1 #

Patch Set 2 : Cleanup of preparser-process.cc #

Total comments: 2

Patch Set 3 : Added TODO with bugnumber for R #

Unified diffs Side-by-side diffs Delta from patch set Stats (+800 lines, -109 lines) Patch
M include/v8-preparser.h View 1 chunk +2 lines, -1 line 0 comments Download
M preparser/preparser-process.cc View 1 4 chunks +166 lines, -18 lines 0 comments Download
M src/parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M src/preparse-data.h View 3 chunks +3 lines, -29 lines 0 comments Download
M src/preparse-data.cc View 1 chunk +1 line, -0 lines 0 comments Download
A src/preparse-data-format.h View 1 chunk +62 lines, -0 lines 0 comments Download
M src/preparser.h View 9 chunks +26 lines, -5 lines 0 comments Download
M src/preparser.cc View 6 chunks +47 lines, -4 lines 0 comments Download
M src/preparser-api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/scanner-base.h View 6 chunks +22 lines, -14 lines 0 comments Download
M src/scanner-base.cc View 1 2 5 chunks +31 lines, -26 lines 0 comments Download
A test/preparser/non-use-strict-hex-escape.js View 1 chunk +35 lines, -0 lines 0 comments Download
A test/preparser/non-use-strict-octal-escape.js View 1 chunk +35 lines, -0 lines 0 comments Download
A test/preparser/non-use-strict-uhex-escape.js View 1 chunk +35 lines, -0 lines 0 comments Download
A test/preparser/preparser.expectation View 1 chunk +12 lines, -0 lines 0 comments Download
A test/preparser/preparser.status View 1 chunk +39 lines, -0 lines 0 comments Download
A test/preparser/strict-octal-directive-after.js View 1 chunk +35 lines, -0 lines 0 comments Download
A test/preparser/strict-octal-directive-before.js View 1 chunk +35 lines, -0 lines 0 comments Download
A test/preparser/strict-octal-indirect-regexp.js View 1 chunk +34 lines, -0 lines 0 comments Download
A test/preparser/strict-octal-regexp.js View 1 chunk +34 lines, -0 lines 0 comments Download
A test/preparser/strict-octal-string.js View 1 chunk +34 lines, -0 lines 0 comments Download
A test/preparser/strict-octal-use-strict-after.js View 1 chunk +35 lines, -0 lines 0 comments Download
A test/preparser/strict-octal-use-strict-before.js View 1 chunk +35 lines, -0 lines 0 comments Download
M test/preparser/testcfg.py View 3 chunks +28 lines, -3 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
9 years, 7 months ago (2011-05-06 08:14:23 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/6927075/diff/3001/src/scanner-base.cc File src/scanner-base.cc (right): http://codereview.chromium.org/6927075/diff/3001/src/scanner-base.cc#newcode735 src/scanner-base.cc:735: // At some point, parse RegExps more throughly ...
9 years, 7 months ago (2011-05-06 10:32:45 UTC) #2
Lasse Reichstein
9 years, 7 months ago (2011-05-06 11:39:24 UTC) #3
http://codereview.chromium.org/6927075/diff/3001/src/scanner-base.cc
File src/scanner-base.cc (right):

http://codereview.chromium.org/6927075/diff/3001/src/scanner-base.cc#newcode735
src/scanner-base.cc:735: // At some point, parse RegExps more throughly to
capture
Done.

Powered by Google App Engine
This is Rietveld 408576698