Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 6927015: NaCl: Add the integrated runtime (IRT) library to install images (Closed)

Created:
9 years, 7 months ago by Mark Seaborn
Modified:
9 years, 5 months ago
Reviewers:
bradn
CC:
chromium-reviews, pam+watch_chromium.org, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

NaCl: Add the integrated runtime (IRT) library to install images Mac (x86-32 only): chrome/chrome_dll.gypi Linux (x86-32 or x86-64, depending on the target arch): chrome/chrome_installer.gypi chrome/tools/build/linux/FILES.cfg Windows (both x86-32 and x86-64 in the same install image) chrome/installer/mini_installer.gyp chrome/installer/mini_installer/chrome.release chrome/tools/build/win/FILES.cfg I am not sure if I need to add to the lists in chrome/tools/build/{linux,win}/FILES. Since there are files listed in FILES.cfg that are not in FILES, I will assume not. BUG=http://code.google.com/p/nativeclient/issues/detail?id=1595 TEST=not sure how to test this, apart from manually testing the install images that are produced after this is committed Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84252

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M chrome/chrome_dll.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_installer.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/installer/mini_installer.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/tools/build/linux/FILES.cfg View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
9 years, 7 months ago (2011-05-04 17:59:36 UTC) #1
bradn
LGTM
9 years, 7 months ago (2011-05-04 18:23:43 UTC) #2
bradn
9 years, 7 months ago (2011-05-04 18:28:30 UTC) #3
Oh and on closer inspection, I don't think you need the p4 location as this is a
nexe.

Powered by Google App Engine
This is Rietveld 408576698