Avoid exiting the renderer process if it has a pending render view.

content/browser/tab_contents/render_view_host_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_TAB_CONTENTS_RENDER_VIEW_HOST_MANAGER_H_
 #define CONTENT_BROWSER_TAB_CONTENTS_RENDER_VIEW_HOST_MANAGER_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/browser/renderer_host/render_view_host_delegate.h"
+#include "content/common/notification_observer.h"
 #include "content/common/notification_registrar.h"
 
 class WebUI;
 class InterstitialPage;
 class NavigationController;
 class NavigationEntry;
 class Profile;
 class RenderWidgetHostView;
 class RenderViewHost;
 class SiteInstance;
 
 // Manages RenderViewHosts for a TabContents. Normally there is only one and
 // it is easy to do. But we can also have transitions of processes (and hence
 // RenderViewHosts) that can get complex.
 class RenderViewHostManager
-    : public RenderViewHostDelegate::RendererManagement {
+    : public RenderViewHostDelegate::RendererManagement,
+      public NotificationObserver {
  public:
   // Functions implemented by our owner that we need.
   //
   // TODO(brettw) Clean this up! These are all the functions in TabContents that
   // are required to run this class. The design should probably be better such
   // that these are more clear.
   //
   // There is additional complexity that some of the functions we need in
   // TabContents are inherited and non-virtual. These are named with
   // "RenderManager" so that the duplicate implementation of them will be clear.
@@ skipping 67 matching lines @@
   RenderViewHost* pending_render_view_host() const {
     return pending_render_view_host_;
   }
 
   // Returns the current committed Web UI or NULL if none applies.
   WebUI* web_ui() const { return web_ui_.get(); }
 
   // Returns the Web UI for the pending navigation, or NULL of none applies.
   WebUI* pending_web_ui() const { return pending_web_ui_.get(); }
 
+  // NotificationObserver.

[jam, 2011/05/10 04:45:18]

nit: the usual style is to add the inherited methods in order that the
interfaces are listed.  so this should go at line 181

[Charlie Reis, 2011/05/10 18:42:19]

Done.

+  virtual void Observe(NotificationType type,
+                       const NotificationSource& source,
+                       const NotificationDetails& details);
+
   // Called when we want to instruct the renderer to navigate to the given
   // navigation entry. It may create a new RenderViewHost or re-use an existing
   // one. The RenderViewHost to navigate will be returned. Returns NULL if one
   // could not be created.
   RenderViewHost* Navigate(const NavigationEntry& entry);
 
   // Instructs the various live views to stop. Called when the user directed the
   // page to stop loading.
   void Stop();
 
@@ skipping 91 matching lines @@
   // Sets the pending RenderViewHost/WebUI to be the active one. Note that this
   // doesn't require the pending render_view_host_ pointer to be non-NULL, since
   // there could be Web UI switching as well. Call this for every commit.
   void CommitPending();
 
   // Helper method to terminate the pending RenderViewHost.
   void CancelPending();
 
   RenderViewHost* UpdateRendererStateForNavigate(const NavigationEntry& entry);
 
+  // Called when a renderer process is starting to close.  We should not
+  // schedule new navigations in its swapped out RenderViewHosts after this.
+  void RendererProcessClosing(RenderProcessHost* render_process_host);
+
   // Our delegate, not owned by us. Guaranteed non-NULL.
   Delegate* delegate_;
 
   // Whether a navigation requiring different RenderView's is pending. This is
   // either cross-site request is (in the new process model), or when required
   // for the view type (like view source versus not).
   bool cross_navigation_pending_;
 
   // Implemented by the owner of this class, this delegate is installed into all
   // the RenderViewHosts that we create.
@@ skipping 27 matching lines @@
 };
 
 // The "details" for a NOTIFY_RENDER_VIEW_HOST_CHANGED notification. The old
 // host can be NULL when the first RenderViewHost is set.
 struct RenderViewHostSwitchedDetails {
   RenderViewHost* old_host;
   RenderViewHost* new_host;
 };
 
 #endif  // CONTENT_BROWSER_TAB_CONTENTS_RENDER_VIEW_HOST_MANAGER_H_