Avoid exiting the renderer process if it has a pending render view.

content/browser/tab_contents/tab_contents.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/tab_contents/tab_contents.h"
 
 #include <cmath>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
@@ skipping 241 matching lines @@
       base_tab_contents->view()->GetContainerSize() : gfx::Size());
 
   // Register for notifications about all interested prefs change.
   PrefService* prefs = profile->GetPrefs();
   pref_change_registrar_.Init(prefs);
   if (prefs) {
     for (int i = 0; i < kPrefsToObserveLength; ++i)
       pref_change_registrar_.Add(kPrefsToObserve[i], this);
   }
 
+  registrar_.Add(this, NotificationType::RENDERER_PROCESS_CLOSING,
+                 NotificationService::AllSources());
   registrar_.Add(this, NotificationType::RENDER_WIDGET_HOST_DESTROYED,
                  NotificationService::AllSources());
 #if defined(OS_LINUX)
   registrar_.Add(this, NotificationType::BROWSER_THEME_CHANGED,
                  NotificationService::AllSources());
 #endif
 
   registrar_.Add(this, NotificationType::USER_STYLE_SHEET_UPDATED,
                  NotificationService::AllSources());
 
@@ skipping 1869 matching lines @@
         UpdateZoomLevel();
       } else if (*pref_name_in == prefs::kEnableReferrers) {
         renderer_preferences_util::UpdateFromSystemSettings(
             &renderer_preferences_, profile());
         render_view_host()->SyncRendererPrefs();
       } else {
         NOTREACHED() << "unexpected pref change notification" << *pref_name_in;
       }
       break;
     }
+    case NotificationType::RENDERER_PROCESS_CLOSING:

[jam, 2011/05/06 17:45:11]

why do you listen to this in TabContents and then just have it call
RenderManager?  i.e. why doesn't render_manager_ listen to the notification
itself?

[Charlie Reis, 2011/05/10 00:57:03]

RenderViewHostManager wasn't a NotificationObserver, and adding a registrar
seemed unnecessary if TabContents is already notifying RVHM about events from
the outside world.

I've switched it over as you suggest, though, which lets us avoid exposing the
RendererProcessClosing function.

+      render_manager_.RendererProcessClosing(
+          Source<RenderProcessHost>(source).ptr());
+      break;
+
     case NotificationType::RENDER_WIDGET_HOST_DESTROYED:
       view_->RenderWidgetHostDestroyed(Source<RenderWidgetHost>(source).ptr());
       break;
 
     case NotificationType::NAV_ENTRY_COMMITTED: {
       DCHECK(&controller_ == Source<NavigationController>(source).ptr());
 
       NavigationController::LoadCommittedDetails& committed_details =
           *(Details<NavigationController::LoadCommittedDetails>(details).ptr());
       ExpireInfoBars(committed_details);
@@ skipping 79 matching lines @@
 
 void TabContents::CreateViewAndSetSizeForRVH(RenderViewHost* rvh) {
   RenderWidgetHostView* rwh_view = view()->CreateViewForWidget(rvh);
   rwh_view->SetSize(view()->GetContainerSize());
 }
 
 void TabContents::OnOnlineStateChanged(bool online) {
   render_view_host()->Send(new ViewMsg_NetworkStateChanged(
       render_view_host()->routing_id(), online));
 }