Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 6927013: Fix bug in x64 >>> operator. (Closed)

Created:
9 years, 7 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix bug in x64 >>> operator. Whenever >>> produces a non-smi result, the binary op stub would return a wrong result in case of a failed new-space allocation. This also fixes the (flaky) sparse-array-reverse test which was failing sometimes because of this. BUG=v8:1359 TEST=mjsunit/sparse-array-reverse.js Committed: http://code.google.com/p/v8/source/detail?r=7790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/x64/code-stubs-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years, 7 months ago (2011-05-04 16:19:18 UTC) #1
Kevin Millikin (Chromium)
9 years, 7 months ago (2011-05-05 07:29:15 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698