Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 6927009: Actually revert "Add Call method to the Object class in the API" (Closed)

Created:
9 years, 7 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Actually revert "Add Call method to the Object class in the API" Tests are failing in debug mode. This also reapplies the change "Make Date and RegExp inherit from Object in the API" that I accidentally reverted. R=sgjesse@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7775

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -247 lines) Patch
M include/v8.h View 3 chunks +81 lines, -89 lines 0 comments Download
M src/api.h View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/execution.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/execution.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +46 lines, -100 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
9 years, 7 months ago (2011-05-04 11:05:18 UTC) #1
Søren Thygesen Gjesse
9 years, 7 months ago (2011-05-04 11:14:24 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698