chrome/browser/ui/cocoa/keystone_infobar.mm - Issue 6926001: Replace the virtual InfoBarDelegate::InfoBarClosed() function with a non-virtual one. This is a ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/keystone_infobar.mm

Issue 6926001: Replace the virtual InfoBarDelegate::InfoBarClosed() function with a non-virtual one. This is a ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/infobars/mock_link_infobar_delegate.cc ('k') | chrome/browser/ui/collected_cookies_infobar_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/keystone_infobar.mm

===================================================================

--- chrome/browser/ui/cocoa/keystone_infobar.mm (revision 84141)

+++ chrome/browser/ui/cocoa/keystone_infobar.mm (working copy)

@@ -47,13 +47,12 @@

// ConfirmInfoBarDelegate

virtual bool ShouldExpire(

- const NavigationController::LoadCommittedDetails& details) const;

- virtual void InfoBarClosed();

- virtual gfx::Image* GetIcon() const;

- virtual string16 GetMessageText() const;

- virtual string16 GetButtonLabel(InfoBarButton button) const;

- virtual bool Accept();

- virtual bool Cancel();

+ const NavigationController::LoadCommittedDetails& details) const OVERRIDE;

+ virtual gfx::Image* GetIcon() const OVERRIDE;

+ virtual string16 GetMessageText() const OVERRIDE;

+ virtual string16 GetButtonLabel(InfoBarButton button) const OVERRIDE;

+ virtual bool Accept() OVERRIDE;

+ virtual bool Cancel() OVERRIDE;

// The TabContents' profile.

Profile* profile_; // weak

@@ -88,10 +87,6 @@

return can_expire_;

}

-void KeystonePromotionInfoBarDelegate::InfoBarClosed() {

- delete this;

gfx::Image* KeystonePromotionInfoBarDelegate::GetIcon() const {

return &ResourceBundle::GetSharedInstance().GetNativeImageNamed(

IDR_PRODUCT_ICON_32);