Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6196)

Unified Diff: chrome/browser/tab_contents/tab_contents_ssl_helper.cc

Issue 6926001: Replace the virtual InfoBarDelegate::InfoBarClosed() function with a non-virtual one. This is a ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/tab_contents_ssl_helper.cc
===================================================================
--- chrome/browser/tab_contents/tab_contents_ssl_helper.cc (revision 84141)
+++ chrome/browser/tab_contents/tab_contents_ssl_helper.cc (working copy)
@@ -42,13 +42,12 @@
virtual ~SSLCertAddedInfoBarDelegate();
// ConfirmInfoBarDelegate:
- virtual void InfoBarClosed();
- virtual gfx::Image* GetIcon() const;
- virtual Type GetInfoBarType() const;
- virtual string16 GetMessageText() const;
- virtual int GetButtons() const;
- virtual string16 GetButtonLabel(InfoBarButton button) const;
- virtual bool Accept();
+ virtual gfx::Image* GetIcon() const OVERRIDE;
+ virtual Type GetInfoBarType() const OVERRIDE;
+ virtual string16 GetMessageText() const OVERRIDE;
+ virtual int GetButtons() const OVERRIDE;
+ virtual string16 GetButtonLabel(InfoBarButton button) const OVERRIDE;
+ virtual bool Accept() OVERRIDE;
TabContents* tab_contents_; // The TabContents we are attached to.
scoped_refptr<net::X509Certificate> cert_; // The cert we added.
@@ -65,11 +64,6 @@
SSLCertAddedInfoBarDelegate::~SSLCertAddedInfoBarDelegate() {
}
-void SSLCertAddedInfoBarDelegate::InfoBarClosed() {
- // ConfirmInfoBarDelegate doesn't delete itself.
- delete this;
-}
-
gfx::Image* SSLCertAddedInfoBarDelegate::GetIcon() const {
return GetCertIcon();
}
« no previous file with comments | « chrome/browser/tab_contents/simple_alert_infobar_delegate.cc ('k') | chrome/browser/translate/translate_infobar_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698