chrome/browser/extensions/extension_disabled_infobar_delegate.cc - Issue 6926001: Replace the virtual InfoBarDelegate::InfoBarClosed() function with a non-virtual one. This is a ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_disabled_infobar_delegate.cc

Issue 6926001: Replace the virtual InfoBarDelegate::InfoBarClosed() function with a non-virtual one. This is a ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_request_infobar_delegate.cc ('k') | chrome/browser/extensions/extension_infobar_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_disabled_infobar_delegate.cc

===================================================================

--- chrome/browser/extensions/extension_disabled_infobar_delegate.cc (revision 84141)

+++ chrome/browser/extensions/extension_disabled_infobar_delegate.cc (working copy)

@@ -87,16 +87,15 @@

virtual ~ExtensionDisabledInfobarDelegate();

// ConfirmInfoBarDelegate:

- virtual void InfoBarClosed();

- virtual string16 GetMessageText() const;

- virtual int GetButtons() const;

- virtual string16 GetButtonLabel(InfoBarButton button) const;

- virtual bool Accept();

+ virtual string16 GetMessageText() const OVERRIDE;

+ virtual int GetButtons() const OVERRIDE;

+ virtual string16 GetButtonLabel(InfoBarButton button) const OVERRIDE;

+ virtual bool Accept() OVERRIDE;

// NotificationObserver:

virtual void Observe(NotificationType type,

const NotificationSource& source,

- const NotificationDetails& details);

+ const NotificationDetails& details) OVERRIDE;

NotificationRegistrar registrar_;

TabContents* tab_contents_;

@@ -122,10 +121,6 @@

ExtensionDisabledInfobarDelegate::~ExtensionDisabledInfobarDelegate() {

}

-void ExtensionDisabledInfobarDelegate::InfoBarClosed() {

- delete this;

string16 ExtensionDisabledInfobarDelegate::GetMessageText() const {

return l10n_util::GetStringFUTF16(extension_->is_app() ?

IDS_APP_DISABLED_INFOBAR_LABEL : IDS_EXTENSION_DISABLED_INFOBAR_LABEL,