Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: chrome/browser/ui/cocoa/infobars/mock_link_infobar_delegate.h

Issue 6926001: Replace the virtual InfoBarDelegate::InfoBarClosed() function with a non-virtual one. This is a ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/infobars/mock_link_infobar_delegate.h
===================================================================
--- chrome/browser/ui/cocoa/infobars/mock_link_infobar_delegate.h (revision 83922)
+++ chrome/browser/ui/cocoa/infobars/mock_link_infobar_delegate.h (working copy)
@@ -15,7 +15,16 @@
class MockLinkInfoBarDelegate : public LinkInfoBarDelegate {
Nico 2011/05/04 21:15:52 (btw, why are all these mocks mac-specific? that s
Peter Kasting 2011/05/04 22:54:56 Dunno. TBH I don't really find infobar_controller
public:
- MockLinkInfoBarDelegate();
+ // Called when |this| is about to be destroyed.
+ class Owner {
+ public:
+ virtual void OnInfoBarDelegateClosed() = 0;
+
+ protected:
+ virtual ~Owner() {}
+ };
+
+ explicit MockLinkInfoBarDelegate(Owner* owner);
virtual ~MockLinkInfoBarDelegate();
void set_dont_close_on_action() { closes_on_action_ = false; }
@@ -23,26 +32,24 @@
bool message_text_accessed() const { return message_text_accessed_; }
bool link_text_accessed() const { return link_text_accessed_; }
bool link_clicked() const { return link_clicked_; }
- bool closed() const { return closed_; }
static const char kMessage[];
static const char kLink[];
private:
// LinkInfoBarDelegate:
- virtual void InfoBarClosed() OVERRIDE;
virtual gfx::Image* GetIcon() const OVERRIDE;
virtual string16 GetMessageTextWithOffset(size_t* link_offset) const OVERRIDE;
virtual string16 GetLinkText() const OVERRIDE;
virtual bool LinkClicked(WindowOpenDisposition disposition) OVERRIDE;
+ Owner* owner_;
// Determines whether the infobar closes when an action is taken or not.
bool closes_on_action_;
mutable bool icon_accessed_;
mutable bool message_text_accessed_;
mutable bool link_text_accessed_;
bool link_clicked_;
- bool closed_;
DISALLOW_COPY_AND_ASSIGN(MockLinkInfoBarDelegate);
};

Powered by Google App Engine
This is Rietveld 408576698