Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: chrome/browser/prerender/prerender_observer.cc

Issue 6915019: Changes to not use the prerendered contents when window.opener needs to be set. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Synced for Commit. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prerender/prerender_observer.h" 5 #include "chrome/browser/prerender/prerender_observer.h"
6 6
7 #include "base/time.h" 7 #include "base/time.h"
8 #include "chrome/browser/prerender/prerender_manager.h" 8 #include "chrome/browser/prerender/prerender_manager.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "content/browser/tab_contents/tab_contents.h" 10 #include "content/browser/tab_contents/tab_contents.h"
11 #include "content/common/view_messages.h" 11 #include "content/common/view_messages.h"
12 12
13 namespace prerender { 13 namespace prerender {
14 14
15 PrerenderObserver::PrerenderObserver(TabContents* tab_contents) 15 PrerenderObserver::PrerenderObserver(TabContents* tab_contents)
16 : TabContentsObserver(tab_contents), 16 : TabContentsObserver(tab_contents),
17 pplt_load_start_() { 17 pplt_load_start_() {
18 } 18 }
19 19
20 PrerenderObserver::~PrerenderObserver() { 20 PrerenderObserver::~PrerenderObserver() {
21 } 21 }
22 22
23 void PrerenderObserver::ProvisionalChangeToMainFrameUrl(const GURL& url) { 23 void PrerenderObserver::ProvisionalChangeToMainFrameUrl(const GURL& url,
24 bool has_opener_set) {
24 PrerenderManager* prerender_manager = MaybeGetPrerenderManager(); 25 PrerenderManager* prerender_manager = MaybeGetPrerenderManager();
25 if (!prerender_manager) 26 if (!prerender_manager)
26 return; 27 return;
27 if (prerender_manager->IsTabContentsPrerendering(tab_contents())) 28 if (prerender_manager->IsTabContentsPrerendering(tab_contents()))
28 return; 29 return;
29 prerender_manager->MarkTabContentsAsNotPrerendered(tab_contents()); 30 prerender_manager->MarkTabContentsAsNotPrerendered(tab_contents());
30 MaybeUsePreloadedPage(url); 31 MaybeUsePreloadedPage(url, has_opener_set);
31 prerender_manager->RecordNavigation(url); 32 prerender_manager->RecordNavigation(url);
32 } 33 }
33 34
34 bool PrerenderObserver::OnMessageReceived(const IPC::Message& message) { 35 bool PrerenderObserver::OnMessageReceived(const IPC::Message& message) {
35 IPC_BEGIN_MESSAGE_MAP(PrerenderObserver, message) 36 IPC_BEGIN_MESSAGE_MAP(PrerenderObserver, message)
36 IPC_MESSAGE_HANDLER(ViewHostMsg_DidStartProvisionalLoadForFrame, 37 IPC_MESSAGE_HANDLER(ViewHostMsg_DidStartProvisionalLoadForFrame,
37 OnDidStartProvisionalLoadForFrame) 38 OnDidStartProvisionalLoadForFrame)
38 IPC_END_MESSAGE_MAP() 39 IPC_END_MESSAGE_MAP()
39 return false; 40 return false;
40 } 41 }
41 42
42 void PrerenderObserver::OnDidStartProvisionalLoadForFrame(int64 frame_id, 43 void PrerenderObserver::OnDidStartProvisionalLoadForFrame(int64 frame_id,
43 bool is_main_frame, 44 bool is_main_frame,
45 bool has_opener_set,
44 const GURL& url) { 46 const GURL& url) {
45 // Don't include prerendered pages in the PPLT metric until after they are 47 // Don't include prerendered pages in the PPLT metric until after they are
46 // swapped in. 48 // swapped in.
47 if (IsPrerendering()) 49 if (IsPrerendering())
48 return; 50 return;
49 if (is_main_frame) { 51 if (is_main_frame) {
50 // Record the beginning of a new PPLT navigation. 52 // Record the beginning of a new PPLT navigation.
51 pplt_load_start_ = base::TimeTicks::Now(); 53 pplt_load_start_ = base::TimeTicks::Now();
52 } 54 }
53 } 55 }
(...skipping 11 matching lines...) Expand all
65 } 67 }
66 68
67 // Reset the PPLT metric. 69 // Reset the PPLT metric.
68 pplt_load_start_ = base::TimeTicks(); 70 pplt_load_start_ = base::TimeTicks();
69 } 71 }
70 72
71 PrerenderManager* PrerenderObserver::MaybeGetPrerenderManager() { 73 PrerenderManager* PrerenderObserver::MaybeGetPrerenderManager() {
72 return tab_contents()->profile()->GetPrerenderManager(); 74 return tab_contents()->profile()->GetPrerenderManager();
73 } 75 }
74 76
75 bool PrerenderObserver::MaybeUsePreloadedPage(const GURL& url) { 77 bool PrerenderObserver::MaybeUsePreloadedPage(const GURL& url,
78 bool has_opener_set) {
76 PrerenderManager* prerender_manager = MaybeGetPrerenderManager(); 79 PrerenderManager* prerender_manager = MaybeGetPrerenderManager();
77 if (!prerender_manager) 80 if (!prerender_manager)
78 return false; 81 return false;
79 DCHECK(!prerender_manager->IsTabContentsPrerendering(tab_contents())); 82 DCHECK(!prerender_manager->IsTabContentsPrerendering(tab_contents()));
80 if (prerender_manager->MaybeUsePreloadedPage(tab_contents(), url)) 83 return prerender_manager->MaybeUsePreloadedPage(tab_contents(),
81 return true; 84 url,
82 return false; 85 has_opener_set);
83 } 86 }
84 87
85 bool PrerenderObserver::IsPrerendering() { 88 bool PrerenderObserver::IsPrerendering() {
86 PrerenderManager* prerender_manager = MaybeGetPrerenderManager(); 89 PrerenderManager* prerender_manager = MaybeGetPrerenderManager();
87 if (!prerender_manager) 90 if (!prerender_manager)
88 return false; 91 return false;
89 return prerender_manager->IsTabContentsPrerendering(tab_contents()); 92 return prerender_manager->IsTabContentsPrerendering(tab_contents());
90 } 93 }
91 94
92 } // namespace prerender 95 } // namespace prerender
OLDNEW
« no previous file with comments | « chrome/browser/prerender/prerender_observer.h ('k') | chrome/browser/prerender/prerender_render_view_host_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698