Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Side by Side Diff: chrome/browser/prerender/prerender_observer.cc

Issue 6915019: Changes to not use the prerendered contents when window.opener needs to be set. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Uploading synced version for commit. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prerender/prerender_observer.h" 5 #include "chrome/browser/prerender/prerender_observer.h"
6 6
7 #include "base/time.h" 7 #include "base/time.h"
8 #include "chrome/browser/prerender/prerender_manager.h" 8 #include "chrome/browser/prerender/prerender_manager.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "content/browser/tab_contents/tab_contents.h" 10 #include "content/browser/tab_contents/tab_contents.h"
11 #include "content/common/view_messages.h" 11 #include "content/common/view_messages.h"
12 12
13 namespace prerender { 13 namespace prerender {
14 14
15 PrerenderObserver::PrerenderObserver(TabContents* tab_contents) 15 PrerenderObserver::PrerenderObserver(TabContents* tab_contents)
16 : TabContentsObserver(tab_contents), 16 : TabContentsObserver(tab_contents),
17 pplt_load_start_() { 17 pplt_load_start_() {
18 } 18 }
19 19
20 PrerenderObserver::~PrerenderObserver() { 20 PrerenderObserver::~PrerenderObserver() {
21 } 21 }
22 22
23 void PrerenderObserver::ProvisionalChangeToMainFrameUrl(const GURL& url) { 23 void PrerenderObserver::ProvisionalChangeToMainFrameUrl(const GURL& url,
24 bool has_opener_set) {
24 PrerenderManager* prerender_manager = MaybeGetPrerenderManager(); 25 PrerenderManager* prerender_manager = MaybeGetPrerenderManager();
25 if (!prerender_manager) 26 if (!prerender_manager)
26 return; 27 return;
27 if (prerender_manager->IsTabContentsPrerendering(tab_contents())) 28 if (prerender_manager->IsTabContentsPrerendering(tab_contents()))
28 return; 29 return;
29 prerender_manager->MarkTabContentsAsNotPrerendered(tab_contents()); 30 prerender_manager->MarkTabContentsAsNotPrerendered(tab_contents());
30 MaybeUsePreloadedPage(url); 31 MaybeUsePreloadedPage(url, has_opener_set);
31 } 32 }
32 33
33 bool PrerenderObserver::OnMessageReceived(const IPC::Message& message) { 34 bool PrerenderObserver::OnMessageReceived(const IPC::Message& message) {
34 IPC_BEGIN_MESSAGE_MAP(PrerenderObserver, message) 35 IPC_BEGIN_MESSAGE_MAP(PrerenderObserver, message)
35 IPC_MESSAGE_HANDLER(ViewHostMsg_DidStartProvisionalLoadForFrame, 36 IPC_MESSAGE_HANDLER(ViewHostMsg_DidStartProvisionalLoadForFrame,
36 OnDidStartProvisionalLoadForFrame) 37 OnDidStartProvisionalLoadForFrame)
37 IPC_END_MESSAGE_MAP() 38 IPC_END_MESSAGE_MAP()
38 return false; 39 return false;
39 } 40 }
40 41
41 void PrerenderObserver::OnDidStartProvisionalLoadForFrame(int64 frame_id, 42 void PrerenderObserver::OnDidStartProvisionalLoadForFrame(int64 frame_id,
42 bool is_main_frame, 43 bool is_main_frame,
44 bool has_opener_set,
43 const GURL& url) { 45 const GURL& url) {
44 // Don't include prerendered pages in the PPLT metric until after they are 46 // Don't include prerendered pages in the PPLT metric until after they are
45 // swapped in. 47 // swapped in.
46 if (IsPrerendering()) 48 if (IsPrerendering())
47 return; 49 return;
48 if (is_main_frame) { 50 if (is_main_frame) {
49 // Record the beginning of a new PPLT navigation. 51 // Record the beginning of a new PPLT navigation.
50 pplt_load_start_ = base::TimeTicks::Now(); 52 pplt_load_start_ = base::TimeTicks::Now();
51 } 53 }
52 } 54 }
(...skipping 11 matching lines...) Expand all
64 } 66 }
65 67
66 // Reset the PPLT metric. 68 // Reset the PPLT metric.
67 pplt_load_start_ = base::TimeTicks(); 69 pplt_load_start_ = base::TimeTicks();
68 } 70 }
69 71
70 PrerenderManager* PrerenderObserver::MaybeGetPrerenderManager() { 72 PrerenderManager* PrerenderObserver::MaybeGetPrerenderManager() {
71 return tab_contents()->profile()->GetPrerenderManager(); 73 return tab_contents()->profile()->GetPrerenderManager();
72 } 74 }
73 75
74 bool PrerenderObserver::MaybeUsePreloadedPage(const GURL& url) { 76 bool PrerenderObserver::MaybeUsePreloadedPage(const GURL& url,
77 bool has_opener_set) {
75 PrerenderManager* prerender_manager = MaybeGetPrerenderManager(); 78 PrerenderManager* prerender_manager = MaybeGetPrerenderManager();
76 if (!prerender_manager) 79 if (!prerender_manager)
77 return false; 80 return false;
78 DCHECK(!prerender_manager->IsTabContentsPrerendering(tab_contents())); 81 DCHECK(!prerender_manager->IsTabContentsPrerendering(tab_contents()));
79 if (prerender_manager->MaybeUsePreloadedPage(tab_contents(), url)) 82 return prerender_manager->MaybeUsePreloadedPage(tab_contents(),
80 return true; 83 url,
81 return false; 84 has_opener_set);
82 } 85 }
83 86
84 bool PrerenderObserver::IsPrerendering() { 87 bool PrerenderObserver::IsPrerendering() {
85 PrerenderManager* prerender_manager = MaybeGetPrerenderManager(); 88 PrerenderManager* prerender_manager = MaybeGetPrerenderManager();
86 if (!prerender_manager) 89 if (!prerender_manager)
87 return false; 90 return false;
88 return prerender_manager->IsTabContentsPrerendering(tab_contents()); 91 return prerender_manager->IsTabContentsPrerendering(tab_contents());
89 } 92 }
90 93
91 } // namespace prerender 94 } // namespace prerender
OLDNEW
« no previous file with comments | « chrome/browser/prerender/prerender_observer.h ('k') | chrome/browser/prerender/prerender_render_view_host_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698