Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7730)

Unified Diff: chrome/renderer/autofill/autofill_agent.cc

Issue 6915003: Don't dismiss Autofill suggestions when clicking on a field that currently has a popup open. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/autofill/autofill_agent.cc
diff --git a/chrome/renderer/autofill/autofill_agent.cc b/chrome/renderer/autofill/autofill_agent.cc
index ba88fa319b06761d2369136ee0082bf625be6bf1..aced4806f6798c621ab99c9e02c31aa451314cb6 100644
--- a/chrome/renderer/autofill/autofill_agent.cc
+++ b/chrome/renderer/autofill/autofill_agent.cc
@@ -310,7 +310,8 @@ void AutofillAgent::ShowSuggestions(const WebInputElement& element,
bool requires_caret_at_end,
bool display_warning_if_disabled) {
if (!element.isEnabled() || element.isReadOnly() || !element.autoComplete() ||
- !element.isTextField() || element.isPasswordField())
+ !element.isTextField() || element.isPasswordField() ||
+ !element.suggestedValue().isEmpty())
return;
// If the field has no name, then we won't have values.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698