Modifying the BackgroundModeManager to handle multiple profiles.

chrome/browser/background_application_list_model.h

Index: chrome/browser/background_application_list_model.h
===================================================================
--- chrome/browser/background_application_list_model.h	(revision 85413)
+++ chrome/browser/background_application_list_model.h	(working copy)
@@ -32,11 +32,12 @@
    public:
     // Invoked when data that the model associates with the extension, such as
     // the Icon, has changed.
-    virtual void OnApplicationDataChanged(const Extension* extension);
+    virtual void OnApplicationDataChanged(const Extension* extension,
+                                          Profile* profile);
 
     // Invoked when the model detects a previously unknown extension and/or when
     // it no longer detects a previously known extension.
-    virtual void OnApplicationListChanged();
+    virtual void OnApplicationListChanged(Profile* profile);
 
    protected:
     virtual ~Observer();
@@ -110,11 +111,11 @@
 
   // Notifies observers that some of the data associated with this background
   // application, e. g. the Icon, has changed.
-  void OnApplicationDataChanged(const Extension* extension);
+  void OnApplicationDataChanged(const Extension* extension, Profile* profile);

[Andrew T Wilson (Slow), 2011/05/20 00:22:09]

I'm curious why we need to pass in the Profile here, since
BackgroundApplicationListManager maintains its own reference to the parent
profile (I'm presuming it's invalid to invoke OnApplicationDataChanged() passing
a profile != profile_, correct?)

[rpetterson, 2011/05/20 05:53:17]

I also commented on the other comment. But BackgroundModeManager also inherts
from BackgroundApplicationListModel::Application and needs to know which profile
it's dealing with.

I'll add the check you mention to the BackgroundApplicationListModel definition
of this function though I don't think it ever gets called.

[Andrew T Wilson (Slow), 2011/05/20 16:52:45]

So, I think you still need to pass a Profile to
BackgroundApplicationListManager::Observer::OnApplicationDataChanged(). But
there's no reason why the private function in
BackgroundApplicationListManager::OnApplicationDataChanged() (which is
unfortunately named identically to the function in Observer) needs to take a
Profile.

[rpetterson, 2011/05/23 03:23:19]

Done.

 
   // Notifies observers that at least one background application has been added
   // or removed.
-  void OnApplicationListChanged();
+  void OnApplicationListChanged(Profile* profile);
 
   // Invoked by Observe for EXTENSION_LOADED notifications.
   void OnExtensionLoaded(Extension* extension);