Compact Navigation prototype

chrome/browser/ui/views/dropdown_bar_host.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_DROPDOWN_BAR_HOST_H_
 #define CHROME_BROWSER_UI_VIEWS_DROPDOWN_BAR_HOST_H_
 #pragma once
 
 #include "base/memory/scoped_ptr.h"
 #include "content/common/native_web_keyboard_event.h"
@@ skipping 27 matching lines @@
 // obscuring the selection results in FindBar.
 //
 ////////////////////////////////////////////////////////////////////////////////
 class DropdownBarHost : public views::AcceleratorTarget,
                         public views::FocusChangeListener,
                         public ui::AnimationDelegate {
  public:
   explicit DropdownBarHost(BrowserView* browser_view);
   virtual ~DropdownBarHost();
 
+  class Delegate {

[sky, 2011/05/03 18:38:32]

Declare this in a separate class so folks don't need to include DropdownBarHost
to implement the delegate.

[SteveT, 2011/05/06 18:48:43]

From what we can see in many other places, the Delegate class is always declared
within the class it belongs to. Has this standard changed somewhere?

[sky, 2011/05/06 19:56:06]

From https://sites.google.com/a/chromium.org/dev/developers/coding-style:

"Prefer putting delegate classes in their own header files. Implementors of the
delegate interface will often be included elsewhere, which will often cause more
coupling with the header of the main class."

[SteveT, 2011/05/06 22:13:40]

Done.

+   public:
+    // Claims focus for the text field and selects its contents.
+    virtual void SetFocusAndSelection(bool select_all) = 0;
+
+    // Updates the view to let it know where the host is clipping the
+    // dropdown widget (while animating the opening or closing of the widget).
+    virtual void set_animation_offset(int offset) = 0;
+  };
+
   // Initializes the dropdown bar host with the give view.

[sky, 2011/05/03 18:38:32]

'give' -> 'given'

[SteveT, 2011/05/06 18:48:43]

Done.

-  void Init(DropdownBarView* view);
+  void Init(views::View* view, Delegate* delegate);

[sky, 2011/05/03 18:38:32]

Can delegate be passed to the constructor?

[SteveT, 2011/05/06 18:48:43]

It gets a bit hairy here if I move the Delegate into the ctor. |view| then has
to be moved as well, since both uses of this code passes the same class into
|view| and |delegate|. Then we have to move FindBarHost's instantiation of
FindBarView (which is passed into |view| and |delegate|) out of it's
constructor, which is bad since we pass a pointer of FindBarHost into
FindBarView at instantiation time.

 
   // Whether we are animating the position of the dropdown widget.
   bool IsAnimating() const;
   // Returns true if the dropdown bar view is visible, or false otherwise.
   bool IsVisible() const;
   // Selects text in the entry field and set focus.
   void SetFocusAndSelection();
   // Stops the animation.
   void StopAnimation();
 
@@ skipping 34 matching lines @@
   // classes registers by using overrides of RegisterAccelerators). See also:
   // SetFocusChangeListener().
   virtual void RegisterAccelerators();
 
   // When we loose focus, we unregister all accelerator handlers. See also:
   // SetFocusChangeListener().
   virtual void UnregisterAccelerators();
 
  protected:
   // Returns the dropdown bar view.
-  DropdownBarView* view() const { return view_; }
+  views::View* view() const { return view_; }
 
   // Returns the focus tracker.
   views::ExternalFocusTracker* focus_tracker() const {
     return focus_tracker_.get();
   }
 
   // Resets the focus tracker.
   void ResetFocusTracker();
 
   // The focus manager we register with to keep track of focus changes.
@@ skipping 32 matching lines @@
   // Returns the animation for the dropdown.
   ui::SlideAnimation* animation() {
     return animation_.get();
   }
 
  private:
   // The BrowserView that created us.
   BrowserView* browser_view_;
 
   // Our view, which is responsible for drawing the UI.
-  DropdownBarView* view_;
+  views::View* view_;
+  Delegate* delegate_;
 
   // The y position pixel offset of the widget while animating the
   // dropdown widget.
   int animation_offset_;
 
   // The animation class to use when opening the Dropdown widget.
   scoped_ptr<ui::SlideAnimation> animation_;
 
   // The focus manager we register with to keep track of focus changes.
   views::FocusManager* focus_manager_;
@@ skipping 11 matching lines @@
   scoped_ptr<views::Widget> host_;
 
   // A flag to manually manage visibility. GTK/X11 is asynchronous and
   // the state of the widget can be out of sync.
   bool is_visible_;
 
   DISALLOW_COPY_AND_ASSIGN(DropdownBarHost);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_DROPDOWN_BAR_HOST_H_