Issue 6913021: Tiny refactoring - change compilation phase parameter for CopyForInlining from a boolean to an enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6913021: Tiny refactoring - change compilation phase parameter for CopyForInlining from a boolean to an enum. (Closed)

Created:
9 years, 7 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Tiny refactoring - change compilation phase parameter for CopyForInlining from a boolean to an enum. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7782

Patch Set 1 #

Total comments: 1

Patch Set 2 : Reformat some line splitting. #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
M	src/arm/lithium-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	src/hydrogen.cc	View	1	3 chunks	+9 lines, -4 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/lithium-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

9 years, 7 months ago (2011-05-03 11:50:23 UTC) #2

LGTM.

http://codereview.chromium.org/6913021/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/6913021/diff/1/src/hydrogen.cc#newcode4108
src/hydrogen.cc:4108: HEnvironment* inner_env = environment()->CopyForInlining(
I prefer breaking at an operator if possible, rather than the dangling "(",
which offends the lisper in me:

HEnvironment* inner_env =
    environment()->CopyForInlining(target,
                                   function,
                                   HEnvironment::HYDROGEN,
                                   undefined);

and it uses the same number of lines.

Expand Messages | Collapse Messages