Issue 6912031: Add Indic and Thai fonts to install-build-deps.sh.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6912031: Add Indic and Thai fonts to install-build-deps.sh. (Closed)

Created:
9 years, 7 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add Indic and Thai fonts to install-build-deps.sh. This will make it easier for people to run webkit layout tests on Lucid. BUG=80681 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83922

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	build/install-build-deps.sh	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

9 years, 7 months ago (2011-05-03 18:20:58 UTC) #2

LGTM

On Tue, May 3, 2011 at 10:52 AM,  <tony@chromium.org> wrote:
> Reviewers: Evan Martin,
>
> Description:
> Add Indic and Thai fonts to install-build-deps.sh.
>
> This will make it easier for people to run webkit layout tests
> on Lucid.
>
> BUG=80681
>
>
> Please review this at http://codereview.chromium.org/6912031/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M build/install-build-deps.sh
>
>
> Index: build/install-build-deps.sh
> diff --git a/build/install-build-deps.sh b/build/install-build-deps.sh
> index
>
b30e08a4023929a77a1f1f6dcf4590f6ecd71afb..b300d71c8790e3ea41d5e6eb83b275773f80de72
> 100755
> --- a/build/install-build-deps.sh
> +++ b/build/install-build-deps.sh
> @@ -158,7 +158,8 @@ dev_list="bison fakeroot flex g++ gperf
> libapache2-mod-php5 libasound2-dev
>           libsctp-dev libsqlite3-dev libxslt1-dev libxss-dev libxtst-dev
>           mesa-common-dev msttcorefonts patch perl php5-cgi pkg-config
> python
>           python-dev rpm subversion ttf-dejavu-core ttf-kochi-gothic
> -          ttf-kochi-mincho wdiff libcurl4-gnutls-dev
> +          ttf-kochi-mincho wdiff libcurl4-gnutls-dev ttf-indic-fonts
> +          ttf-thai-tlwg
>           $chromeos_dev_list"
>
>  # Run-time libraries required by chromeos only
>
>
>

Expand Messages | Collapse Messages