Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Issue 6912021: Fix implementation of == to correctly convert Date objects to primitives. (Closed)

Created:
9 years, 7 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Karl Klose
CC:
v8-dev
Visibility:
Public.

Description

Fix implementation of == to correctly convert Date objects to primitives. Fix issue 1356 BUG=v8:1356 TEST=mjsunit/double-equals Committed: http://code.google.com/p/v8/source/detail?r=7761

Patch Set 1 #

Patch Set 2 : Added more case for Date #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -86 lines) Patch
M src/runtime.js View 1 chunk +28 lines, -22 lines 0 comments Download
M test/mjsunit/double-equals.js View 1 1 chunk +186 lines, -64 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
9 years, 7 months ago (2011-05-03 12:02:12 UTC) #1
Karl Klose
9 years, 7 months ago (2011-05-03 12:11:27 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698