Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 6912001: Merge 83754 - blob_storage_controller.cc assert from this bug was caused by the fact that worker ... (Closed)

Created:
9 years, 7 months ago by zel
Modified:
9 years, 6 months ago
Reviewers:
zel
CC:
chromium-reviews, jam, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merge 83754 - blob_storage_controller.cc assert from this bug was caused by the fact that worker thread actually run in a different renderer process from the main page JS thread. chrome.fileBrowserPrivate.* methods grant access to files through ChildProcessSecurityPolicy class, but such file permissions would end up associated with renderer process of the main thread only. When worker tries to register blobs representing such files, ChildProcessSecurityPolicy check would reject it since its client process id has nothing to do with main renderer's id. This CL adds mapping between worker and main renderer processes and uses that to ensure that worker thread renderer process file permissions are "inherited" from its main JS thread renderer child process. BUG=chromium-os:14680 TEST=added extra tests to ChildProcessSecurityPolicyTest.FilePermissions Review URL: http://codereview.chromium.org/6893145 TBR=zelidrag@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -13 lines) Patch
M content/browser/child_process_security_policy.h View 3 chunks +21 lines, -1 line 0 comments Download
M content/browser/child_process_security_policy.cc View 4 chunks +37 lines, -11 lines 0 comments Download
M content/browser/child_process_security_policy_unittest.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
zel
9 years, 7 months ago (2011-05-02 20:20:07 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698