Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 6911024: Add HostObserverInterface and decouple HeartbeatSender and ChromotingHost. (Closed)

Created:
9 years, 7 months ago by Sergey Ulanov
Modified:
9 years, 7 months ago
Reviewers:
Wez, Alpha Left Google
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, Paweł Hajdan Jr., dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Add HostObserverInterface and decouple HeartbeatSender and ChromotingHost. BUG=None TEST=Everything still works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83951

Patch Set 1 : - #

Total comments: 6

Patch Set 2 : virtual destructor! #

Patch Set 3 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -112 lines) Patch
M chrome/service/remoting/chromoting_host_manager.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M remoting/host/chromoting_host.h View 4 chunks +8 lines, -4 lines 0 comments Download
M remoting/host/chromoting_host.cc View 7 chunks +34 lines, -30 lines 0 comments Download
M remoting/host/heartbeat_sender.h View 5 chunks +14 lines, -17 lines 0 comments Download
M remoting/host/heartbeat_sender.cc View 4 chunks +36 lines, -40 lines 0 comments Download
M remoting/host/heartbeat_sender_unittest.cc View 3 chunks +9 lines, -18 lines 0 comments Download
A remoting/host/host_status_observer.h View 1 1 chunk +34 lines, -0 lines 0 comments Download
M remoting/host/simple_host_process.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M remoting/jingle_glue/jingle_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/jingle_glue/jingle_thread.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/remoting.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Ulanov
9 years, 7 months ago (2011-05-03 03:17:09 UTC) #1
Wez
LGTM, with a few nits. http://codereview.chromium.org/6911024/diff/2001/chrome/service/remoting/chromoting_host_manager.cc File chrome/service/remoting/chromoting_host_manager.cc (right): http://codereview.chromium.org/6911024/diff/2001/chrome/service/remoting/chromoting_host_manager.cc#newcode15 chrome/service/remoting/chromoting_host_manager.cc:15: #include "remoting/host/host_key_pair.h" What's host_key_pair.h ...
9 years, 7 months ago (2011-05-03 05:21:50 UTC) #2
Sergey Ulanov
http://codereview.chromium.org/6911024/diff/2001/chrome/service/remoting/chromoting_host_manager.cc File chrome/service/remoting/chromoting_host_manager.cc (right): http://codereview.chromium.org/6911024/diff/2001/chrome/service/remoting/chromoting_host_manager.cc#newcode15 chrome/service/remoting/chromoting_host_manager.cc:15: #include "remoting/host/host_key_pair.h" On 2011/05/03 05:21:50, Wez wrote: > What's ...
9 years, 7 months ago (2011-05-03 17:24:18 UTC) #3
Wez
On 2011/05/03 17:24:18, sergeyu wrote: > http://codereview.chromium.org/6911024/diff/2001/chrome/service/remoting/chromoting_host_manager.cc > File chrome/service/remoting/chromoting_host_manager.cc (right): > > http://codereview.chromium.org/6911024/diff/2001/chrome/service/remoting/chromoting_host_manager.cc#newcode15 > ...
9 years, 7 months ago (2011-05-03 18:22:28 UTC) #4
Sergey Ulanov
9 years, 7 months ago (2011-05-03 18:37:25 UTC) #5
On 2011/05/03 18:22:28, Wez wrote:
> On 2011/05/03 17:24:18, sergeyu wrote:
> >
>
http://codereview.chromium.org/6911024/diff/2001/chrome/service/remoting/chro...
> > File chrome/service/remoting/chromoting_host_manager.cc (right):
> > 
> >
>
http://codereview.chromium.org/6911024/diff/2001/chrome/service/remoting/chro...
> > chrome/service/remoting/chromoting_host_manager.cc:15: #include
> > "remoting/host/host_key_pair.h"
> > On 2011/05/03 05:21:50, Wez wrote:
> > > What's host_key_pair.h used for here?
> > HostKeyPair is used here to generate private key and write it in the config.
> 
> My point is that no new code using HostKeyPair was added to
> chromoting_host_manager.cc, so why is this include now required, where it
wasn't
> before?
chromoting_host.h was previously including heartbeat_sender.h which includes
host_key_pair.h. Here I removed heartbeat_sender.h include from
chromoting_host.h, so this file stopped compiling without host_key_pair.h

Powered by Google App Engine
This is Rietveld 408576698