Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 6910022: Replace long running loops by OptimizeFunctionOnNextCall in some tests. (Closed)

Created:
9 years, 7 months ago by Karl Klose
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Replace long running loops by OptimizeFunctionOnNextCall in some tests that are often timing out on ARM.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -9 lines) Patch
M test/mjsunit/closures.js View 1 2 chunks +5 lines, -3 lines 0 comments Download
M test/mjsunit/compiler/regress-closures-with-eval.js View 1 2 chunks +6 lines, -1 line 0 comments Download
M test/mjsunit/compiler/regress-intoverflow.js View 4 chunks +8 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-1099.js View 1 2 chunks +6 lines, -1 line 0 comments Download
M test/mjsunit/strict-mode-opt.js View 4 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Karl Klose
9 years, 7 months ago (2011-05-03 12:31:11 UTC) #1
Mads Ager (chromium)
http://codereview.chromium.org/6910022/diff/1/test/mjsunit/closures.js File test/mjsunit/closures.js (right): http://codereview.chromium.org/6910022/diff/1/test/mjsunit/closures.js#newcode39 test/mjsunit/closures.js:39: %OptimizeFunctionOnNextCall(MyFunction) Maybe call the MyFunction function a couple of ...
9 years, 7 months ago (2011-05-03 13:05:08 UTC) #2
Karl Klose
http://codereview.chromium.org/6910022/diff/1/test/mjsunit/closures.js File test/mjsunit/closures.js (right): http://codereview.chromium.org/6910022/diff/1/test/mjsunit/closures.js#newcode39 test/mjsunit/closures.js:39: %OptimizeFunctionOnNextCall(MyFunction) On 2011/05/03 13:05:08, Mads Ager wrote: > Maybe ...
9 years, 7 months ago (2011-05-03 13:23:22 UTC) #3
Mads Ager (chromium)
9 years, 7 months ago (2011-05-03 13:34:40 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698