Issue 6910021: Cleanup: use xorps to zero out an xmm register on ia32 too.

Issue 6910021: Cleanup: use xorps to zero out an xmm register on ia32 too. (Closed)

Created:
9 years, 7 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Cleanup: use xorps to zero out an xmm register on ia32 too. Encoding is one byte shorter. R=lrn@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7760

Patch Set 2 : Address comments #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -13 lines)			Patch
M	src/ia32/assembler-ia32.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.cc	View		2 chunks	+10 lines, -1 line	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ia32/disasm-ia32.cc	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1	7 chunks	+7 lines, -7 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/6910021/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/6910021/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode2721 src/ia32/lithium-codegen-ia32.cc:2721: __ pxor(scratch, scratch); Change all pxor to xorps ...

9 years, 7 months ago (2011-05-03 11:53:39 UTC) #2

Mads Ager (chromium)

9 years, 7 months ago (2011-05-03 12:00:23 UTC) #3

http://codereview.chromium.org/6910021/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):

http://codereview.chromium.org/6910021/diff/1/src/ia32/lithium-codegen-ia32.c...
src/ia32/lithium-codegen-ia32.cc:2721: __ pxor(scratch, scratch);
On 2011/05/03 11:53:39, Lasse Reichstein wrote:
> Change all pxor to xorps as well (I think this is the only one in this file,
and
> there is one in full-codegen-ia32.cc too).
> The pxor uses integer arithmetic, and it introduces a 1-2 cycle latency when
the
> next instruction is a double instruction (and all our XMM operations are
double
> operations).

Done.

Expand Messages | Collapse Messages