Add method IsPassphraseRequiredForDecryption to ProfileSyncService

Add method IsPassphraseRequiredForDecryption to ProfileSyncService

ProfileSyncService needs to know in multiple places whether a passphrase
is required for decryption. Right now, the logic involves checking
passphrase_required_reason_ against a couple of states.

This patch refactors this logic into the methods:

IsPassphraseRequired
IsPassphraseRequiredForDecryption

BUG=81313, 81341, 81018
TEST=sync_integration_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83923

[Raghu Simha, 2011-05-02 23:47:23]

Tim, please review. Thanks.

http://codereview.chromium.org/6910012/diff/1/chrome/browser/sync/profile_syn...
File chrome/browser/sync/profile_sync_service.cc (right):

http://codereview.chromium.org/6910012/diff/1/chrome/browser/sync/profile_syn...
chrome/browser/sync/profile_sync_service.cc:1206:
IsPassphraseRequiredForEncryption()) {
Tim: This line requires special attention. With the old logic, this used to be
"!passphrase_required_for_decryption_". I believe it's equivalent to
IsPassphraseRequiredForEncryption. Could you confirm?

[tim (not reviewing), 2011-05-03 00:06:59]

http://codereview.chromium.org/6910012/diff/1/chrome/browser/sync/profile_syn...
File chrome/browser/sync/profile_sync_service.cc (right):

http://codereview.chromium.org/6910012/diff/1/chrome/browser/sync/profile_syn...
chrome/browser/sync/profile_sync_service.cc:1206:
IsPassphraseRequiredForEncryption()) {
On 2011/05/02 23:47:23, rsimha wrote:
> Tim: This line requires special attention. With the old logic, this used to be
> "!passphrase_required_for_decryption_". I believe it's equivalent to
> IsPassphraseRequiredForEncryption. Could you confirm?

The previous logic seems to also include NOT_REQUIRED?

http://codereview.chromium.org/6910012/diff/1/chrome/browser/sync/profile_syn...
File chrome/browser/sync/profile_sync_service.h (right):

http://codereview.chromium.org/6910012/diff/1/chrome/browser/sync/profile_syn...
chrome/browser/sync/profile_sync_service.h:298: bool
IsPassphraseRequiredForEncryption() const {
I'm not sure this one is truly necessary / buys us much?

[Raghu Simha, 2011-05-03 00:24:00]

http://codereview.chromium.org/6910012/diff/1/chrome/browser/sync/profile_syn...
File chrome/browser/sync/profile_sync_service.cc (right):

http://codereview.chromium.org/6910012/diff/1/chrome/browser/sync/profile_syn...
chrome/browser/sync/profile_sync_service.cc:1206:
IsPassphraseRequiredForEncryption()) {
On 2011/05/03 00:06:59, timsteele wrote:
> On 2011/05/02 23:47:23, rsimha wrote:
> > Tim: This line requires special attention. With the old logic, this used to
be
> > "!passphrase_required_for_decryption_". I believe it's equivalent to
> > IsPassphraseRequiredForEncryption. Could you confirm?
> 
> The previous logic seems to also include NOT_REQUIRED?

I was talking about the previous previous logic in
http://codereview.chromium.org/6902101/diff/7025/chrome/browser/sync/profile_...
line 1205. But you're right. I've changed this to
!IsPassphraseRequiredForDecryption().

http://codereview.chromium.org/6910012/diff/1/chrome/browser/sync/profile_syn...
File chrome/browser/sync/profile_sync_service.h (right):

http://codereview.chromium.org/6910012/diff/1/chrome/browser/sync/profile_syn...
chrome/browser/sync/profile_sync_service.h:298: bool
IsPassphraseRequiredForEncryption() const {
On 2011/05/03 00:06:59, timsteele wrote:
> I'm not sure this one is truly necessary / buys us much? 

Agreed, it doesn't. Removed.

[tim (not reviewing), 2011-05-03 18:16:56]

LGTM