Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Side by Side Diff: src/ia32/macro-assembler-ia32.h

Issue 6909026: Additional minor cleanup regarding CallWrapper: Use the null object pattern. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 void LoadFromSafepointRegisterSlot(Register dst, Register src); 150 void LoadFromSafepointRegisterSlot(Register dst, Register src);
151 151
152 // --------------------------------------------------------------------------- 152 // ---------------------------------------------------------------------------
153 // JavaScript invokes 153 // JavaScript invokes
154 154
155 // Invoke the JavaScript function code by either calling or jumping. 155 // Invoke the JavaScript function code by either calling or jumping.
156 void InvokeCode(const Operand& code, 156 void InvokeCode(const Operand& code,
157 const ParameterCount& expected, 157 const ParameterCount& expected,
158 const ParameterCount& actual, 158 const ParameterCount& actual,
159 InvokeFlag flag, 159 InvokeFlag flag,
160 CallWrapper* call_wrapper = NULL); 160 const CallWrapper& call_wrapper = NullCallWrapper());
161 161
162 void InvokeCode(Handle<Code> code, 162 void InvokeCode(Handle<Code> code,
163 const ParameterCount& expected, 163 const ParameterCount& expected,
164 const ParameterCount& actual, 164 const ParameterCount& actual,
165 RelocInfo::Mode rmode, 165 RelocInfo::Mode rmode,
166 InvokeFlag flag, 166 InvokeFlag flag,
167 CallWrapper* call_wrapper = NULL); 167 const CallWrapper& call_wrapper = NullCallWrapper());
168 168
169 // Invoke the JavaScript function in the given register. Changes the 169 // Invoke the JavaScript function in the given register. Changes the
170 // current context to the context in the function before invoking. 170 // current context to the context in the function before invoking.
171 void InvokeFunction(Register function, 171 void InvokeFunction(Register function,
172 const ParameterCount& actual, 172 const ParameterCount& actual,
173 InvokeFlag flag, 173 InvokeFlag flag,
174 CallWrapper* call_wrapper = NULL); 174 const CallWrapper& call_wrapper = NullCallWrapper());
175 175
176 void InvokeFunction(JSFunction* function, 176 void InvokeFunction(JSFunction* function,
177 const ParameterCount& actual, 177 const ParameterCount& actual,
178 InvokeFlag flag, 178 InvokeFlag flag,
179 CallWrapper* call_wrapper = NULL); 179 const CallWrapper& call_wrapper = NullCallWrapper());
180 180
181 // Invoke specified builtin JavaScript function. Adds an entry to 181 // Invoke specified builtin JavaScript function. Adds an entry to
182 // the unresolved list if the name does not resolve. 182 // the unresolved list if the name does not resolve.
183 void InvokeBuiltin(Builtins::JavaScript id, 183 void InvokeBuiltin(Builtins::JavaScript id,
184 InvokeFlag flag, 184 InvokeFlag flag,
185 CallWrapper* call_wrapper = NULL); 185 const CallWrapper& call_wrapper = NullCallWrapper());
186 186
187 // Store the function for the given builtin in the target register. 187 // Store the function for the given builtin in the target register.
188 void GetBuiltinFunction(Register target, Builtins::JavaScript id); 188 void GetBuiltinFunction(Register target, Builtins::JavaScript id);
189 189
190 // Store the code object for the given builtin in the target register. 190 // Store the code object for the given builtin in the target register.
191 void GetBuiltinEntry(Register target, Builtins::JavaScript id); 191 void GetBuiltinEntry(Register target, Builtins::JavaScript id);
192 192
193 // Expression support 193 // Expression support
194 void Set(Register dst, const Immediate& x); 194 void Set(Register dst, const Immediate& x);
195 void Set(const Operand& dst, const Immediate& x); 195 void Set(const Operand& dst, const Immediate& x);
(...skipping 446 matching lines...) Expand 10 before | Expand all | Expand 10 after
642 // This handle will be patched with the code object on installation. 642 // This handle will be patched with the code object on installation.
643 Handle<Object> code_object_; 643 Handle<Object> code_object_;
644 644
645 // Helper functions for generating invokes. 645 // Helper functions for generating invokes.
646 void InvokePrologue(const ParameterCount& expected, 646 void InvokePrologue(const ParameterCount& expected,
647 const ParameterCount& actual, 647 const ParameterCount& actual,
648 Handle<Code> code_constant, 648 Handle<Code> code_constant,
649 const Operand& code_operand, 649 const Operand& code_operand,
650 NearLabel* done, 650 NearLabel* done,
651 InvokeFlag flag, 651 InvokeFlag flag,
652 CallWrapper* call_wrapper = NULL); 652 const CallWrapper& call_wrapper = NullCallWrapper());
653 653
654 // Activation support. 654 // Activation support.
655 void EnterFrame(StackFrame::Type type); 655 void EnterFrame(StackFrame::Type type);
656 void LeaveFrame(StackFrame::Type type); 656 void LeaveFrame(StackFrame::Type type);
657 657
658 void EnterExitFramePrologue(); 658 void EnterExitFramePrologue();
659 void EnterExitFrameEpilogue(int argc, bool save_doubles); 659 void EnterExitFrameEpilogue(int argc, bool save_doubles);
660 660
661 void LeaveExitFrameEpilogue(); 661 void LeaveExitFrameEpilogue();
662 662
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
781 } \ 781 } \
782 masm-> 782 masm->
783 #else 783 #else
784 #define ACCESS_MASM(masm) masm-> 784 #define ACCESS_MASM(masm) masm->
785 #endif 785 #endif
786 786
787 787
788 } } // namespace v8::internal 788 } } // namespace v8::internal
789 789
790 #endif // V8_IA32_MACRO_ASSEMBLER_IA32_H_ 790 #endif // V8_IA32_MACRO_ASSEMBLER_IA32_H_
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698