Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 6909026: Additional minor cleanup regarding CallWrapper: Use the null object pattern. (Closed)

Created:
9 years, 7 months ago by Sven Panne
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Additional minor cleanup regarding CallWrapper: Use the null object pattern. Committed: http://code.google.com/p/v8/source/detail?r=7767

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -88 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 5 chunks +10 lines, -12 lines 0 comments Download
M src/assembler.h View 1 1 chunk +10 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 7 chunks +12 lines, -14 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 5 chunks +8 lines, -10 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 4 chunks +9 lines, -9 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 7 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
9 years, 7 months ago (2011-05-03 12:47:15 UTC) #1
Kevin Millikin (Chromium)
LGTM. You could put the default behavior in the base class instead of making the ...
9 years, 7 months ago (2011-05-03 14:19:20 UTC) #2
Sven Panne
On 2011/05/03 14:19:20, Kevin Millikin wrote: > LGTM. You could put the default behavior in ...
9 years, 7 months ago (2011-05-03 15:06:05 UTC) #3
danno
9 years, 7 months ago (2011-05-05 14:21:44 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698