Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 6905167: Implement API to disallow code generation from strings for a context. (Closed)

Created:
9 years, 7 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Implement API to disallow code generation from strings for a context. R=sgjesse@chromium.org BUG=v8:1258 TEST=test-api/AllowCodeGenFromStrings Committed: http://code.google.com/p/v8/source/detail?r=7753

Patch Set 1 #

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -20 lines) Patch
M include/v8.h View 15 chunks +44 lines, -14 lines 0 comments Download
M src/api.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M src/contexts.h View 3 chunks +4 lines, -2 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/messages.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 3 chunks +44 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
9 years, 7 months ago (2011-05-02 15:01:09 UTC) #1
abarth-chromium
That API looks great. Thanks for working on this bug!
9 years, 7 months ago (2011-05-02 18:29:09 UTC) #2
Søren Thygesen Gjesse
9 years, 7 months ago (2011-05-02 20:58:40 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698