Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 6905119: Fix build_image --factory_install to work again. (Closed)

Created:
9 years, 8 months ago by jrbarnette
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, jimhebert, sosa
Visibility:
Public.

Description

Fix build_image --factory_install to work again. There were two bugs: 1) The test [ ${ARCH} -eq "arm" ] was wrong because -eq is a numeric comparison operator, not legal on strings. 2) Variable ${ARCH} was used before set. The code change includes comment changes to clarify the reasons for the code, and a future-proofing logic change. Change-Id: I63f502cc33cf8a9a441b4b305fc49ed57d0a55b1 BUG=None TEST=build_image --factory_install, and boot the resulting image Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b290366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -28 lines) Patch
M build_image View 3 chunks +30 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jrbarnette
This should be self-explanatory. I only need one reviewer, but everybody on the 'To:' list ...
9 years, 8 months ago (2011-04-28 23:05:02 UTC) #1
Mandeep Singh Baines
LGTM
9 years, 8 months ago (2011-04-28 23:16:53 UTC) #2
Nick Sanders
9 years, 8 months ago (2011-04-29 00:08:18 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698